composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-28 22:54:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

n°524 - password policy

Browse Source 
- The code now uses the standard extension method (using interfaces)
 - the metamodel can now filter on iModuleExtension in order to leverage extensions modularity (see MetaModel::EnumPlugins second param)
 - during the setup, there is no pawsord policy control
 - there is now a default policy
 - new (more precie) translation reflecting the default policy
 - fix CI?
This commit is contained in:
bruno DA SILVA
2019-11-25 16:25:38 +01:00
parent 85932eab98
commit 70dfbbc15e
11 changed files with 148 additions and 214 deletions
Download Patch File Download Diff File Expand all files Collapse all files

209
test/coreExtensions/UserLocalTest.php
View File

@@ -10,18 +10,23 @@ namespace coreExtensions;
use Combodo\iTop\Test\UnitTest\ItopTestCase;
use UserLocal;
use UserLocalPasswordPolicyMockNotValid;
use UserLocalPasswordPolicyMockNotValidBis;
use UserLocalPasswordPolicyMockValid;
use UserLocalPasswordPolicyMockValidBis;
use UserLocalPasswordValidity;
use UserPasswordPolicyRegex;
class UserLocalTest extends ItopTestCase
{
public function setUp()
{
parent::setUp(); // TODO: Change the autogenerated stub
parent::setUp();
require_once(APPROOT.'application/startup.inc.php');
require_once (APPROOT.'test/coreExtensions/UserLocalTest/UserLocalPasswordPolicyMock.php');
require_once (APPROOT.'env-production/authent-local/model.authent-local.php');
}
/**
@@ -31,13 +36,13 @@ class UserLocalTest extends ItopTestCase
* @preserveGlobalState disabled
* @backupGlobals disabled
*/
public function testValidatePassword($aValueMap, $sPassword, $bExpectedCheckStatus, $expectedCheckIssues = null)
public function testValidatePassword($sPassword, $aValidatorCollection, $aConfigValueMap, $bExpectedCheckStatus, $expectedCheckIssues = null)
{
$configMock = $this->createMock(\Config::class);
$configMock
->method('GetModuleSetting')
->willReturnMap($aValueMap);
->willReturnMap($aConfigValueMap);
/** @var UserLocal $oUserLocal */
$oUserLocal = \MetaModel::NewObject('UserLocal', array('login' => 'john'));
@@ -48,7 +53,7 @@ class UserLocalTest extends ItopTestCase
\MetaModel::NewObject('URP_UserProfile', array('profileid' => 1))
);
$oUserLocal->ValidatePassword($sPassword, $configMock);
$oUserLocal->ValidatePassword($sPassword, $configMock, $aValidatorCollection);
list($bCheckStatus, $aCheckIssues, $aSecurityIssues) = $oUserLocal->CheckToWrite();
@@ -62,191 +67,107 @@ class UserLocalTest extends ItopTestCase
public function ProviderValidatePassword()
{
parent::setUp();
require_once (APPROOT.'env-production/authent-local/model.authent-local.php');
require_once (APPROOT.'test/coreExtensions/UserLocalTest/UserLocalPasswordPolicyMock.php');
$oUserPasswordPolicyRegex = new UserPasswordPolicyRegex();
$oUserLocalPasswordPolicyMockValid = new UserLocalPasswordPolicyMockValid();
$oUserLocalPasswordPolicyMockNotValid = new UserLocalPasswordPolicyMockNotValid();
$oUserLocalPasswordPolicyMockValidBis = new UserLocalPasswordPolicyMockValidBis();
$oUserLocalPasswordPolicyMockNotValidBis = new UserLocalPasswordPolicyMockNotValidBis();
return array(
'validPattern' => array(
'password' => 'foo',
'aValidatorCollection' => array(
$oUserPasswordPolicyRegex,
),
'valueMap' => array(
array('authent-local', 'password_validation.pattern', null, '.{1,10}')
),
'password' => 'foo',
'expectedCheckStatus' => true,
),
'notValidPattern' => array(
'password' => 'foo',
'aValidatorCollection' => array(
$oUserPasswordPolicyRegex,
),
'valueMap' => array(
array('authent-local', 'password_validation.pattern', null, '.{6,10}')
),
'password' => 'foo',
'expectedCheckStatus' => false,
),
'noPattern' => array(
'password' => 'foo',
'aValidatorCollection' => array(
$oUserPasswordPolicyRegex,
),
'valueMap' => array(
array('authent-local', 'password_validation.pattern', null, '')
),
'password' => 'foo',
'expectedCheckStatus' => true,
),
'validClass' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserLocalPasswordPolicyMock' => array(
'bCheckStatus' => true,
)
)
)
),
'password' => 'foo',
'aValidatorCollection' => array(
$oUserLocalPasswordPolicyMockValid,
),
'valueMap' => array(),
'expectedCheckStatus' => true,
),
'notValidClass' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserLocalPasswordPolicyMock' => array(
'bCheckStatus' => false,
)
)
)
),
'password' => 'foo',
'aValidatorCollection' => array(
$oUserLocalPasswordPolicyMockNotValid,
),
'valueMap' => array(),
'expectedCheckStatus' => false,
),
'UserPasswordPolicyRegex_configured_twice' => array(
'valueMap' => array(
array('authent-local', 'password_validation.pattern', null, '.*'),
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserPasswordPolicyRegex' => array(
'pattern' => '.*',
)
)
)
),
'password' => 'foo',
'expectedCheckStatus' => false,
'expectedCheckIssues' => 'Invalid configuration: \'UserPasswordPolicyRegex\' was defined twice (once into UserLocal.password_validation_advanced, once into UserLocal.password_validation).',
),
'classNotImplementsUserLocalPasswordValidator' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'StdClass' => array()
)
)
),
'password' => 'foo',
'expectedCheckStatus' => false,
'expectedCheckIssues' => 'Invalid configuration: \'StdClass\' must implements UserLocalPasswordValidator',
),
'validation_composition_10' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserLocalPasswordPolicyMock' => array(
'bCheckStatus' => true,
'sCheckIssues' => 'UserLocalPasswordPolicyMock',
),
'UserLocalPasswordPolicyMockBis' => array(
'bCheckStatus' => false,
'sCheckIssues' => 'UserLocalPasswordPolicyMockBis',
),
)
)
),
'password' => 'foo',
'aValidatorCollection' => array(
$oUserLocalPasswordPolicyMockValid,
$oUserLocalPasswordPolicyMockNotValid,
),
'valueMap' => array(),
'expectedCheckStatus' => false,
'expectedCheckIssues' => 'UserLocalPasswordPolicyMockBis',
'expectedCheckIssues' => 'UserLocalPasswordPolicyMockNotValid',
),
'validation_composition_01' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserLocalPasswordPolicyMock' => array(
'bCheckStatus' => false,
'sCheckIssues' => 'UserLocalPasswordPolicyMock',
),
'UserLocalPasswordPolicyMockBis' => array(
'bCheckStatus' => true,
'sCheckIssues' => 'UserLocalPasswordPolicyMockBis',
),
)
)
),
'password' => 'foo',
'aValidatorCollection' => array(
$oUserLocalPasswordPolicyMockNotValid,
$oUserLocalPasswordPolicyMockValid,
),
'valueMap' => array(),
'expectedCheckStatus' => false,
'expectedCheckIssues' => 'UserLocalPasswordPolicyMock',
'expectedCheckIssues' => 'UserLocalPasswordPolicyMockNotValid',
),
'validation_composition_11' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserLocalPasswordPolicyMock' => array(
'bCheckStatus' => true,
'sCheckIssues' => 'UserLocalPasswordPolicyMock',
),
'UserLocalPasswordPolicyMockBis' => array(
'bCheckStatus' => true,
'sCheckIssues' => 'UserLocalPasswordPolicyMockBis',
),
)
)
),
'password' => 'foo',
'aValidatorCollection' => array(
$oUserLocalPasswordPolicyMockValid,
$oUserLocalPasswordPolicyMockValidBis,
),
'valueMap' => array(),
'expectedCheckStatus' => true,
),
'validation_composition_00' => array(
'valueMap' => array(
array(
'authent-local',
'password_validation.classes',
null,
array(
'UserLocalPasswordPolicyMock' => array(
'bCheckStatus' => false,
'sCheckIssues' => 'UserLocalPasswordPolicyMock',
),
'UserLocalPasswordPolicyMockBis' => array(
'bCheckStatus' => false,
'sCheckIssues' => 'UserLocalPasswordPolicyMockBis',
),
)
)
),
'password' => 'foo',
'aValidatorCollection' => array(
$oUserLocalPasswordPolicyMockNotValid,
$oUserLocalPasswordPolicyMockNotValidBis,
),
'valueMap' => array(),
'expectedCheckStatus' => false,
'expectedCheckIssues' => 'UserLocalPasswordPolicyMock',
'expectedCheckIssues' => 'UserLocalPasswordPolicyMockNotValid',
),
);