composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-25 11:38:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°6414 Move existing AbstractSimpleField::Validate impl to custom validators

Browse Source 
- LinkedSetField
- SelectObjectField
- MultipleChoicesField (warning this hierarchy contains non multiple value fields like SelectField !)

Also change AbstractValidator::Validate signature : now we are returning an array of error messages, so that we can return multiple ones
This commit is contained in:
Pierre Goiffon
2023-06-28 17:56:04 +02:00
parent d085f15b6d
commit 6cc2d49cd5
20 changed files with 526 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files

107
tests/php-unit-tests/unitary-tests/sources/Form/MultipleChoicesFieldTest.php Normal file
View File

@@ -0,0 +1,107 @@
<?php
/*
* @copyright Copyright (C) 2010-2023 Combodo SARL
* @license http://opensource.org/licenses/AGPL-3.0
*/
namespace Form;
use Combodo\iTop\Form\Field\MultipleChoicesField;
use Combodo\iTop\Form\Field\MultipleSelectField;
use Combodo\iTop\Form\Field\SelectField;
use Combodo\iTop\Test\UnitTest\ItopTestCase;
use ContextTag;
class MultipleChoicesFieldTest extends ItopTestCase
{
public function testValidateForMultipleSelectField(): void
{
$oMultipleChoicesField = new MultipleSelectField('test');
$oMultipleChoicesField->AddChoice('A');
$oMultipleChoicesField->AddChoice('B');
$oMultipleChoicesField->AddChoice('C');
$oMultipleChoicesField->AddChoice('D');
// N°1150 the control was added for the REST API initially and was only triggered with the corresponding ContextTag
$oRestContext = new ContextTag(ContextTag::TAG_REST);
$this->ValidateMultipleSelectField($oMultipleChoicesField);
// retrying without REST context
unset($oRestContext);
$this->ValidateMultipleSelectField($oMultipleChoicesField);
}
private function ValidateMultipleSelectField(MultipleChoicesField $oMultipleChoicesField): void
{
$oMultipleChoicesField->SetCurrentValue(null);
$this->assertTrue($oMultipleChoicesField->Validate(), 'No value must be valid');
$sExistingValue = 'A';
$sNonExistingValue = 'Non existing choice';
$sNonExistingValue1 = 'Non existing choice 1';
$sNonExistingValue2 = 'Non existing choice 2';
$oMultipleChoicesField->SetCurrentValue($sExistingValue);
$this->assertTrue($oMultipleChoicesField->Validate(), 'Value among possible ones is valid');
$oMultipleChoicesField->SetCurrentValue($sNonExistingValue);
$this->assertFalse($oMultipleChoicesField->Validate(), 'Value not among possible ones is invalid');
$this->assertCount(1, $oMultipleChoicesField->GetErrorMessages());
$this->assertStringContainsString($sNonExistingValue, $oMultipleChoicesField->GetErrorMessages()[0]);
$oMultipleChoicesField->SetCurrentValue([$sNonExistingValue1, $sNonExistingValue2]);
$this->assertFalse($oMultipleChoicesField->Validate(), 'Multiple values not among possible ones is invalid');
$this->assertCount(2, $oMultipleChoicesField->GetErrorMessages());
$this->assertStringContainsString($sNonExistingValue1, $oMultipleChoicesField->GetErrorMessages()[0]);
$this->assertStringContainsString($sNonExistingValue2, $oMultipleChoicesField->GetErrorMessages()[1]);
$oMultipleChoicesField->SetCurrentValue([$sExistingValue, $sNonExistingValue]);
$this->assertFalse($oMultipleChoicesField->Validate(), 'Valid value + Value not among possible ones is invalid');
$this->assertCount(1, $oMultipleChoicesField->GetErrorMessages());
$this->assertStringContainsString($sNonExistingValue, $oMultipleChoicesField->GetErrorMessages()[0]);
$oMultipleChoicesField->SetCurrentValue([$sExistingValue, $sNonExistingValue1, $sNonExistingValue2]);
$this->assertFalse($oMultipleChoicesField->Validate(), 'Valid value + Multiple values not among possible ones is invalid');
$this->assertCount(2, $oMultipleChoicesField->GetErrorMessages());
$this->assertStringContainsString($sNonExistingValue1, $oMultipleChoicesField->GetErrorMessages()[0]);
$this->assertStringContainsString($sNonExistingValue2, $oMultipleChoicesField->GetErrorMessages()[1]);
}
public function testValidateForSelectField(): void
{
$oMultipleChoicesField = new SelectField('test');
$oMultipleChoicesField->AddChoice('A');
$oMultipleChoicesField->AddChoice('B');
$oMultipleChoicesField->AddChoice('C');
$oMultipleChoicesField->AddChoice('D');
// N°1150 the control was added for the REST API initially and was only triggered with the corresponding ContextTag
$oRestContext = new ContextTag(ContextTag::TAG_REST);
$this->ValidateSelectField($oMultipleChoicesField);
// retrying without REST context
unset($oRestContext);
$this->ValidateSelectField($oMultipleChoicesField);
$oMultipleChoicesField = new SelectField('test');
$oMultipleChoicesField->SetChoices(['A' => 'A', 'B' => 'B', 'C' => 'C', 'D' => 'D']);
$this->ValidateSelectField($oMultipleChoicesField);
}
private function ValidateSelectField(MultipleChoicesField $oMultipleChoicesField): void
{
$oMultipleChoicesField->SetCurrentValue(null);
$this->assertTrue($oMultipleChoicesField->Validate(), 'No value must be valid');
$sExistingValue = 'A';
$sNonExistingValue = 'Non existing choice';
$oMultipleChoicesField->SetCurrentValue($sExistingValue);
$this->assertTrue($oMultipleChoicesField->Validate(), 'Value among possible ones is valid');
$oMultipleChoicesField->SetCurrentValue($sNonExistingValue);
$this->assertFalse($oMultipleChoicesField->Validate(), 'Value not among possible ones is invalid');
$this->assertCount(1, $oMultipleChoicesField->GetErrorMessages());
$this->assertStringContainsString($sNonExistingValue, $oMultipleChoicesField->GetErrorMessages()[0]);
}
}