From 125715af3f6d86427b638387a00a3c942faf2e5a Mon Sep 17 00:00:00 2001 From: Molkobain Date: Fri, 14 Jul 2023 21:09:37 +0200 Subject: [PATCH] =?UTF-8?q?N=C2=B06562=20-=20Temporarily=20disable=20XML?= =?UTF-8?q?=20conversion=20unit=20tests=20failing=20in=20PHP=208.2.8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../setup/iTopDesignFormat/iTopDesignFormatTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/iTopDesignFormatTest.php b/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/iTopDesignFormatTest.php index fb0e8edb1..c04b9c224 100644 --- a/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/iTopDesignFormatTest.php +++ b/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/iTopDesignFormatTest.php @@ -57,8 +57,8 @@ class iTopDesignFormatTest extends ItopTestCase $sInputXml = $this->GetFileContent($sSamplesRelDirPath.$sXmlFileName.'.input'); $oInputDesignFormat = static::GetItopFormatFromString($sInputXml); - // N° Disable test for 1.7 => 3.0 conversion on PHP 8.1.21 as it is failing due to unknown reason. Cause will be investigated next week. - if (PHP_VERSION_ID === 80121 + // N°6562 Disable test for 1.7 => 3.0 conversion on PHP 8.1.21 / 8.2.8 as it is failing due to unknown reason. Cause will be investigated next week. + if ((PHP_VERSION_ID === 80121 || PHP_VERSION_ID === 80208) && $oInputDesignFormat->GetVersion() === "1.7" && $sTargetVersion === "3.0") { $this->markTestSkipped("Skip test for 1.7 => 3.0 conversion on PHP 8.1.21 as it is failing due to unknown reason. Cause will be investigated next week."); } @@ -107,8 +107,8 @@ class iTopDesignFormatTest extends ItopTestCase $oExpectedDesignFormat = static::GetItopFormatFromString($sExpectedXml); $sExpectedVersion = $oExpectedDesignFormat->GetVersion(); - // N° Disable test for 1.7 => 3.0 conversion on PHP 8.1.21 as it is failing due to unknown reason. Cause will be investigated next week. - if (PHP_VERSION_ID === 80121 + // N°6562 Disable test for 1.7 => 3.0 conversion on PHP 8.1.21 / 8.2.8 as it is failing due to unknown reason. Cause will be investigated next week. + if ((PHP_VERSION_ID === 80121 || PHP_VERSION_ID === 80208) && $sInputVersion === "1.7" && $sExpectedVersion === "3.0") { $this->markTestSkipped("Skip test for 1.7 => 3.0 conversion on PHP 8.1.21 as it is failing due to unknown reason. Cause will be investigated next week."); }