composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

✅ Update tests to be minimal and removed hard-coded ITOP_DESIGN_LATEST_VERSION VERSION

Browse Source
This commit is contained in:
jf-cbd
2024-10-22 11:47:25 +02:00
parent 72d6e251b8
commit 6becd73ac2
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/php-unit-tests/unitary-tests/setup/ModelFactoryTest.php
View File

@@ -100,6 +100,9 @@ class ModelFactoryTest extends ItopTestCase
*/
protected function AssertEqualModels(string $sExpectedXML, ModelFactory $oFactory, $sMessage = '')
{
// constants aren't accessible in the data provider :(
$sExpectedXML = str_replace('##ITOP_DESIGN_LATEST_VERSION##', ITOP_DESIGN_LATEST_VERSION, $sExpectedXML);
$this->AssertEqualiTopXML($sExpectedXML, $oFactory->Dump(null, true), $sMessage);
}
@@ -3236,7 +3239,7 @@ XML
'aClasses' => [
['name' => 'A', 'module' => 'M', 'parent' => 'cmdbAbstractObject'],
],
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.3">
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="##ITOP_DESIGN_LATEST_VERSION##">
<loaded_modules/>
<classes>
<class id="DBObject"/>
@@ -3266,7 +3269,7 @@ XML
['name' => 'A', 'module' => 'M', 'parent' => 'cmdbAbstractObject'],
['name' => 'B', 'module' => 'M2', 'parent' => 'cmdbAbstractObject'],
],
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.3">
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="##ITOP_DESIGN_LATEST_VERSION##">
<loaded_modules/>
<classes>
<class id="DBObject"/>
@@ -3303,7 +3306,7 @@ XML
['name' => 'A', 'module' => 'M', 'parent' => 'cmdbAbstractObject'],
['name' => 'B', 'module' => 'M2', 'parent' => 'A'],
],
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.3">
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="##ITOP_DESIGN_LATEST_VERSION##">
<loaded_modules/>
<classes>
<class id="DBObject"/>
@@ -3342,7 +3345,7 @@ XML
['name' => 'C', 'module' => 'M3', 'parent' => 'cmdbAbstractObject'],
['name' => 'D', 'module' => 'M3', 'parent' => 'B'],
],
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.3">
'sExpectedXML' => '<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="##ITOP_DESIGN_LATEST_VERSION##">
<loaded_modules/>
<classes>
<class id="DBObject"/>

1
tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.3_to_3.2.expected.xml
View File

@@ -1,4 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.2">
<branding/>
</itop_design>

1
tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.3_to_3.2.input.xml
View File

@@ -1,4 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.2">
<branding/>
</itop_design>