N°4720 - Remove old unreferenced methods or pages that are @deprecated (#747)

* N°4720 - Remove old unreferenced methods that are @deprecated

* N°4720-Config addson getter/setter removal

* small deprecation removal

* revert @deprecation 3.3 removal: ResizeImageToFit

* small deprecation removal

* revert deprecation 3.3 removal: Config/GSetAddons
This commit is contained in:
odain-cbd
2025-09-11 15:52:00 +02:00
committed by GitHub
parent d728be119c
commit 696e2c9565
27 changed files with 126 additions and 1135 deletions

View File

@@ -3,7 +3,7 @@
//
// This file is part of iTop.
//
// iTop is free software; you can redistribute it and/or modify
// iTop is free software; you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
@@ -105,7 +105,7 @@ abstract class ValueSetDefinition
/**
* Set of existing values for an attribute, given a search filter
* Set of existing values for an attribute, given a search filter
*
* @package iTopORM
*/
@@ -125,7 +125,7 @@ class ValueSetObjects extends ValueSetDefinition
/**
* @param hash $aOrderBy Array of '[<classalias>.]attcode' => bAscending
*/
*/
public function __construct($sFilterExp, $sValueAttCode = '', $aOrderBy = array(), $bAllowAllData = false, $aModifierProperties = array())
{
$this->m_sContains = '';
@@ -146,17 +146,6 @@ class ValueSetObjects extends ValueSetDefinition
$this->m_bIsLoaded = false;
}
/**
* @deprecated use SetCondition instead
*
* @param \DBSearch $oFilter
*/
public function AddCondition(DBSearch $oFilter)
{
DeprecatedCallsLog::NotifyDeprecatedPhpMethod('use SetCondition instead');
$this->SetCondition($oFilter);
}
public function SetCondition(DBSearch $oFilter)
{
$this->m_oExtraCondition = $oFilter;
@@ -457,7 +446,7 @@ class ValueSetObjects extends ValueSetDefinition
/**
* Fixed set values (could be hardcoded in the business model)
* Fixed set values (could be hardcoded in the business model)
*
* @package iTopORM
*/
@@ -542,7 +531,7 @@ class ValueSetEnum extends ValueSetDefinition
foreach (explode(",", $this->m_values) as $sVal)
{
$sVal = trim($sVal);
$sKey = $sVal;
$sKey = $sVal;
$aValues[$sKey] = $sVal;
}
}
@@ -613,7 +602,7 @@ class ValueSetRange extends ValueSetDefinition
/**
* Data model classes
* Data model classes
*
* @package iTopORM
*/
@@ -631,7 +620,7 @@ class ValueSetEnumClasses extends ValueSetEnum
{
// Call the parent to parse the additional values...
parent::LoadValues($aArgs);
// Translate the labels of the additional values
foreach($this->m_aValues as $sClass => $void)
{