From 961315cf34a1f9db63ecdaff40397aa8171824a9 Mon Sep 17 00:00:00 2001 From: vdumas Date: Fri, 16 Feb 2024 10:36:57 +0100 Subject: [PATCH 1/2] =?UTF-8?q?N=C2=B06826=20-=20Add=20SQL=20value=20for?= =?UTF-8?q?=20file=20attribute=20in=20DocumentFile?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- datamodels/2.x/itop-structure/datamodel.itop-structure.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datamodels/2.x/itop-structure/datamodel.itop-structure.xml b/datamodels/2.x/itop-structure/datamodel.itop-structure.xml index dcb91e5d9..c34281345 100644 --- a/datamodels/2.x/itop-structure/datamodel.itop-structure.xml +++ b/datamodels/2.x/itop-structure/datamodel.itop-structure.xml @@ -1483,7 +1483,10 @@ - + + file + true + From 5c12151c26b7268ea6e924bdee2adc66aef380d6 Mon Sep 17 00:00:00 2001 From: Molkobain Date: Mon, 19 Feb 2024 09:46:12 +0100 Subject: [PATCH 2/2] :memo: Update PR template --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 68eeeb4b6..e6a8dbc1f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -64,7 +64,7 @@ Don't remove these lines, check them once done. --> - [ ] I have performed a self-review of my code - [ ] I have tested all changes I made on an iTop instance -- [ ] Would a unit test be relevant and have I added it? +- [ ] I have added a unit test, otherwise I have explained why I couldn't - [ ] Is the PR clear and detailled enough so anyone can understand digging in the code? ## Checklist of things to do before PR is ready to merge