From 66bf1dc6fa28095ca59ec5c814e2d35d50be294b Mon Sep 17 00:00:00 2001 From: Timmy38 <101416770+Timmy38@users.noreply.github.com> Date: Mon, 8 Jun 2026 11:45:11 +0200 Subject: [PATCH] =?UTF-8?q?N=C2=B09179=20Fix=20tests=20for=20unattended=20?= =?UTF-8?q?install=20backward=20compatibility?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../ApplicationInstallerSequencerTest.php | 29 ++++++++++++++++--- .../sequencers/DataAuditSequencerTest.php | 16 ++++++++++ 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/tests/php-unit-tests/unitary-tests/setup/sequencers/ApplicationInstallerSequencerTest.php b/tests/php-unit-tests/unitary-tests/setup/sequencers/ApplicationInstallerSequencerTest.php index 5cd4b3bca..7793a92ec 100644 --- a/tests/php-unit-tests/unitary-tests/setup/sequencers/ApplicationInstallerSequencerTest.php +++ b/tests/php-unit-tests/unitary-tests/setup/sequencers/ApplicationInstallerSequencerTest.php @@ -439,6 +439,27 @@ class ApplicationInstallerSequencerTest extends ItopTestCase $this->assertEquals($expected, $this->oSequencer->GetStepNames()); } + public function testDefaultOptionalStepsWhenUsingOldParameters() + { + $aAdditionalParams = [ + 'optional_steps' => null, + ]; + $this->GivenApplicationInstallSequencer($aAdditionalParams, true); + + $expected = [ + '', + 'log-parameters', + 'migrate-before', + 'db-schema', + 'migrate-after', + 'after-db-create', + 'load-data', + 'create-config', + 'commit', + ]; + $this->assertEquals($expected, $this->oSequencer->GetStepNames()); + } + public static function WithoutOneStepProvider() { return [ @@ -482,13 +503,13 @@ class ApplicationInstallerSequencerTest extends ItopTestCase public function testGetStepNamesWithOnlyMandatorySteps() { - $this->GivenApplicationInstallSequencer([], true); + $aAdditionalParams = [ + 'optional_steps' => [], + ]; + $this->GivenApplicationInstallSequencer($aAdditionalParams, true); $expected = [ '', - 'log-parameters', - 'migrate-before', 'db-schema', - 'migrate-after', 'after-db-create', 'load-data', 'create-config', diff --git a/tests/php-unit-tests/unitary-tests/setup/sequencers/DataAuditSequencerTest.php b/tests/php-unit-tests/unitary-tests/setup/sequencers/DataAuditSequencerTest.php index 97dc0bac9..6f81e0b23 100644 --- a/tests/php-unit-tests/unitary-tests/setup/sequencers/DataAuditSequencerTest.php +++ b/tests/php-unit-tests/unitary-tests/setup/sequencers/DataAuditSequencerTest.php @@ -290,6 +290,22 @@ class DataAuditSequencerTest extends ItopTestCase $this->assertEquals($expected, $oSequencer->GetStepNames()); } + public function testDefaultOptionalStepsWhenUsingOldParameters() + { + $oRunTimeEnvironment = $this->createMock(\RunTimeEnvironment::class); + $oParams = $this->GivenParams(); + $oParams->Set('optional_steps', null); + $oSequencer = new DataAuditSequencer($oParams, $oRunTimeEnvironment); + + $expected = [ + '', + 'copy', + 'compile', + 'complete', + ]; + $this->assertEquals($expected, $oSequencer->GetStepNames()); + } + private function GivenParams(array $aAdditionalParams = []): PHPParameters { $oParams = new PHPParameters();