N°7315 - Introduce WebPage::LinkStylesheetXXX() methods to replace WebPage::add_linked_stylesheet()

This commit is contained in:
Molkobain
2024-03-05 22:58:13 +01:00
parent 33ba754277
commit 655539c289
2 changed files with 277 additions and 60 deletions

View File

@@ -22,7 +22,6 @@ class WebPageTest extends ItopDataTestCase
/**
* @dataProvider LinkScriptMethodsProvider
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkScript()
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkScriptFromAppRoot()
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkScriptFromModule()
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkScriptFromURI()
@@ -41,8 +40,8 @@ class WebPageTest extends ItopDataTestCase
$this->InvokeNonPublicMethod(WebPage::class, "EmptyLinkedScripts", $oPage);
$this->InvokeNonPublicMethod(WebPage::class, $sMethodName, $oPage, [$sInputURI]);
$aLinkedScript = $this->GetNonPublicProperty($oPage, "a_linked_scripts");
$this->assertEquals($iExpectedCount, count($aLinkedScript), "Linked scripts count should be $iExpectedCount");
$aLinkedScripts = $this->GetNonPublicProperty($oPage, "a_linked_scripts");
$this->assertEquals($iExpectedCount, count($aLinkedScripts), "Linked scripts count should be $iExpectedCount");
}
public function LinkScriptMethodsProvider(): array
@@ -110,4 +109,94 @@ class WebPageTest extends ItopDataTestCase
],
];
}
/**
* @dataProvider LinkStylesheetMethodsProvider
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkStylesheetFromAppRoot()
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkStylesheetFromModule()
* @covers \Combodo\iTop\Application\WebPage\WebPage::LinkStylesheetFromURI()
*
* @param string $sMethodName
* @param string $sInputURI
* @param int $iExpectedCount
*
* @return void
* @throws \ReflectionException
*/
public function testLinkStylesheetMethods(string $sMethodName, string $sInputURI, int $iExpectedCount): void
{
$oPage = new WebPageMock('');
$this->InvokeNonPublicMethod(WebPage::class, "EmptyLinkedStylesheets", $oPage);
$this->InvokeNonPublicMethod(WebPage::class, $sMethodName, $oPage, [$sInputURI]);
$aLinkedStylesheets = $this->GetNonPublicProperty($oPage, "a_linked_stylesheets");
$this->assertEquals($iExpectedCount, count($aLinkedStylesheets), "Linked stylesheets count should be $iExpectedCount");
}
public function LinkStylesheetMethodsProvider(): array
{
return [
// LinkStylesheetFromAppRoot
"LinkStylesheetFromAppRoot: Empty URI should be ignored" => [
"LinkStylesheetFromAppRoot",
"",
0,
],
"LinkStylesheetFromAppRoot: Relative URI of existing file should be completed / added" => [
"LinkStylesheetFromAppRoot",
"css/login.css",
1,
],
"LinkStylesheetFromAppRoot: Relative URI of NON existing file should be ignored" => [
"LinkStylesheetFromAppRoot",
"css/some-file.css",
0,
],
"LinkStylesheetFromAppRoot: Absolute URI should be ignored" => [
"LinkStylesheetFromAppRoot",
"https://external.server/file.css",
0,
],
// LinkStylesheetFromModule
"LinkStylesheetFromModule: Empty URI should be ignored" => [
"LinkStylesheetFromModule",
"",
0,
],
"LinkStylesheetFromModule: Relative URI of existing file should be completed / added" => [
"LinkStylesheetFromModule",
"itop-portal-base/portal/public/css/portal.css",
1,
],
"LinkStylesheetFromModule: Relative URI of NON existing file should be completed / added" => [
"LinkStylesheetFromModule",
"some-module/asset/js/some-file.js",
0,
],
"LinkStylesheetFromModule: Absolute URI should be ignored" => [
"LinkStylesheetFromModule",
"https://external.server/file.js",
0,
],
// LinkStylesheetFromURI
"LinkStylesheetFromURI: Empty URI should be ignored" => [
"LinkStylesheetFromURI",
"",
0,
],
"LinkStylesheetFromURI: Relative URI should be ignored" => [
"LinkStylesheetFromURI",
"js/login.css",
0,
],
"LinkStylesheetFromURI: Absolute URI should be added" => [
"LinkStylesheetFromURI",
"https://external.server/file.css",
1,
],
];
}
}