From 6c6131ce0357cac06c6995f257356a35cfa2c991 Mon Sep 17 00:00:00 2001 From: odain Date: Fri, 15 Sep 2023 10:07:42 +0200 Subject: [PATCH] =?UTF-8?q?N=C2=B05491=20-=20test=20enhancement=20to=20red?= =?UTF-8?q?uce=20false=20positive?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../DictionariesConsistencyAfterSetupTest.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/php-unit-tests/integration-tests/DictionariesConsistencyAfterSetupTest.php b/tests/php-unit-tests/integration-tests/DictionariesConsistencyAfterSetupTest.php index 8b54282f6..4c6446910 100644 --- a/tests/php-unit-tests/integration-tests/DictionariesConsistencyAfterSetupTest.php +++ b/tests/php-unit-tests/integration-tests/DictionariesConsistencyAfterSetupTest.php @@ -151,6 +151,12 @@ class DictionariesConsistencyAfterSetupTest extends ItopTestCase $aMismatchedKeys = []; foreach ($aKeyArgsCountMap[$sReferenceLangCode] as $sKey => $iExpectedNbOfArgs){ + if (0 === $iExpectedNbOfArgs){ + //no arg needed in EN. + //let s assume job has been done correctly in EN to simplify + continue; + } + if (in_array($sKey, self::$aLabelCodeNotToCheck)){ //false positive: do not test continue;