composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 11:08:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rename constants according to @steffunky 's advice (better DX)

Browse Source
This commit is contained in:
Molkobain
2021-02-19 18:35:20 +01:00
parent ea502e9c81
commit 5e21ec03cd
5 changed files with 36 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
sources/application/UI/Base/Layout/TabContainer/Tab/AjaxTab.php
View File

@@ -33,20 +33,38 @@ use utils;
* @internal
* @since 3.0.0
*/
class AjaxTab extends Tab {
class AjaxTab extends Tab
{
const ENUM_TAB_PLACEHOLDER_REL_PATH_LIST = 'images/placeholders/skeleton-list.svg';
const ENUM_TAB_PLACEHOLDER_REL_PATH_DASHBOARD = 'images/placeholders/skeleton-dashboard.svg';
const ENUM_TAB_PLACEHOLDER_REL_PATH_OBJECT = 'images/placeholders/skeleton-object.svg';
const ENUM_TAB_PLACEHOLDER_REL_PATH_MISC = 'images/placeholders/skeleton.svg';
/**
* @see static::$sPlaceholderRelPath
* @var string
*/
public const ENUM_TAB_PLACEHOLDER_LIST = 'images/placeholders/skeleton-list.svg';
/**
* @see static::$sPlaceholderRelPath
* @var string
*/
public const ENUM_TAB_PLACEHOLDER_DASHBOARD = 'images/placeholders/skeleton-dashboard.svg';
/**
* @see static::$sPlaceholderRelPath
* @var string
*/
public const ENUM_TAB_PLACEHOLDER_OBJECT = 'images/placeholders/skeleton-object.svg';
/**
* @see static::$sPlaceholderRelPath
* @var string
*/
public const ENUM_TAB_PLACEHOLDER_MISC = 'images/placeholders/skeleton.svg';
/** @var string */
public const DEFAULT_TAB_PLACEHOLDER = self::ENUM_TAB_PLACEHOLDER_MISC;
const DEFAULT_TAB_PLACEHOLDER_REL_PATH = self::ENUM_TAB_PLACEHOLDER_REL_PATH_MISC;
// Overloaded constants
public const BLOCK_CODE = 'ibo-ajax-tab';
public const TAB_TYPE = TabManager::ENUM_TAB_TYPE_AJAX;
/** @var string Placeholder displayed before tab is loaded */
/** @var string Placeholder displayed before tab is loaded (relative path from the app. root) */
private $sPlaceholderRelPath;
/** @var string The target URL to be loaded asynchronously */
private $sUrl;
@@ -60,11 +78,12 @@ class AjaxTab extends Tab {
* @param string $sTitle
* @param string $sPlaceholderRelPath
*/
public function __construct(string $sTabCode, string $sTitle, string $sPlaceholderRelPath = AjaxTab::DEFAULT_TAB_PLACEHOLDER_REL_PATH)
public function __construct(string $sTabCode, string $sTitle, string $sPlaceholderRelPath = AjaxTab::DEFAULT_TAB_PLACEHOLDER)
{
parent::__construct($sTabCode, $sTitle);
$this->sPlaceholderRelPath = $sPlaceholderRelPath;
}
/**
* @param string $sUrl
*

2
sources/application/UI/Base/Layout/TabContainer/TabContainer.php
View File

@@ -121,7 +121,7 @@ class TabContainer extends UIContentBlock
public function AddAjaxTab(string $sTabCode, string $sTitle, ?string $sPlaceholder = null): Tab
{
if($sPlaceholder === null){
$sPlaceholder = AjaxTab::DEFAULT_TAB_PLACEHOLDER_REL_PATH;
$sPlaceholder = AjaxTab::DEFAULT_TAB_PLACEHOLDER;
}
$oTab = new AjaxTab($sTabCode, $sTitle, $sPlaceholder);
$this->AddSubBlock($oTab);