diff --git a/datamodels/2.x/itop-portal-base/portal/src/controllers/objectcontroller.class.inc.php b/datamodels/2.x/itop-portal-base/portal/src/controllers/objectcontroller.class.inc.php index f7e3ee82a6..787c6e6296 100644 --- a/datamodels/2.x/itop-portal-base/portal/src/controllers/objectcontroller.class.inc.php +++ b/datamodels/2.x/itop-portal-base/portal/src/controllers/objectcontroller.class.inc.php @@ -1379,7 +1379,8 @@ class ObjectController extends AbstractController } // Checking security layers - if (!SecurityHelper::IsActionAllowed($oApp, UR_ACTION_READ, $sHostClass, $sHostId)) + // Note: Checking if host object already exists as we can try to download document from an object that is being created + if (($sHostId > 0) && !SecurityHelper::IsActionAllowed($oApp, UR_ACTION_READ, $sHostClass, $sHostId)) { IssueLog::Warning(__METHOD__ . ' at line ' . __LINE__ . ' : User #' . UserRights::GetUserId() . ' not allowed to retrieve document from attribute ' . $sObjectField . ' as it not allowed to read ' . $sHostClass . '::' . $sHostId . ' object.'); $oApp->abort(404, Dict::S('UI:ObjectDoesNotExist')); diff --git a/sources/renderer/bootstrap/fieldrenderer/bsfileuploadfieldrenderer.class.inc.php b/sources/renderer/bootstrap/fieldrenderer/bsfileuploadfieldrenderer.class.inc.php index 2326abc2cb..49713e1241 100644 --- a/sources/renderer/bootstrap/fieldrenderer/bsfileuploadfieldrenderer.class.inc.php +++ b/sources/renderer/bootstrap/fieldrenderer/bsfileuploadfieldrenderer.class.inc.php @@ -115,7 +115,7 @@ class BsFileUploadFieldRenderer extends FieldRenderer $(this).closest('.fileupload_field_content').find('.attachments_container').append( '
'+ - ' '+ + ' '+ '
'+ '
'+data.result.msg+'
'+ ' '+ @@ -127,7 +127,7 @@ class BsFileUploadFieldRenderer extends FieldRenderer if(data.result.preview){ $('#display_attachment_'+data.result.att_id).tooltip({ html: true, - title: function(){ return ''; } + title: function(){ return '
'; } }); } // Showing remove button on hover @@ -163,7 +163,7 @@ class BsFileUploadFieldRenderer extends FieldRenderer $('.attachment [data-preview="true"]').each(function(iIndex, oElem){ $(oElem).parent().tooltip({ html: true, - title: function(){ return ''; } + title: function(){ return '
'; } }); }); // Remove button handler @@ -229,10 +229,14 @@ EOF return $oOutput; } - /** - * - * @param RenderingOutput $oOutput - */ + /** + * + * @param \Combodo\iTop\Renderer\RenderingOutput $oOutput + * + * @throws \Exception + * @throws \CoreException + * @throws \OQLException + */ protected function PrepareExistingFiles(RenderingOutput &$oOutput) { $sObjectClass = get_class($this->oField->GetObject()); @@ -262,7 +266,7 @@ EOF $oOutput->Addhtml( << -
+
{$sFileName}