From 5729d6a9cd091d4c6d6c82dd69892c84505d25f3 Mon Sep 17 00:00:00 2001 From: Pierre Goiffon Date: Wed, 11 Jan 2023 10:02:59 +0100 Subject: [PATCH] :art: :white_check_mark: StatusIncTest : fix phpdoc, replace `@expectedException` --- .../application/status/StatusIncTest.php | 29 +++++-------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/tests/php-unit-tests/unitary-tests/sources/application/status/StatusIncTest.php b/tests/php-unit-tests/unitary-tests/sources/application/status/StatusIncTest.php index c53240572..c09ae0731 100644 --- a/tests/php-unit-tests/unitary-tests/sources/application/status/StatusIncTest.php +++ b/tests/php-unit-tests/unitary-tests/sources/application/status/StatusIncTest.php @@ -1,21 +1,12 @@ InvokeNonPublicMethod("Combodo\iTop\Application\Status\Status", "StatusCheckConfigFile", $oStatus, [$sConfigFilenamewrong]); } - /** - * - */ public function testStatusCheckConfigFileGood() { $oStatus = new Status(); $this->InvokeNonPublicMethod("Combodo\iTop\Application\Status\Status", "StatusCheckConfigFile", $oStatus, []); @@ -82,10 +70,9 @@ class StatusIncTest extends ItopTestCase { $this->assertTrue(true); } - /** - * @expectedException \MySQLException - */ - public function testStatusStartupWrongDbPwd() { + public function testStatusStartupWrongDbPwd() + { + $this->expectException(MySQLException::class); $oStatus = new Status(); $this->InvokeNonPublicMethod("Combodo\iTop\Application\Status\Status", "StatusCheckConfigFile", $oStatus, []); @@ -93,9 +80,9 @@ class StatusIncTest extends ItopTestCase { $this->RequireOnceItopFile('application/utils.inc.php'); $this->RequireOnceItopFile('core/contexttag.class.inc.php'); - $oConfigWrong = new Config(ITOP_DEFAULT_CONFIG_FILE); - $oConfigWrong->Set('db_pwd', $oConfigWrong->Get('db_pwd') . '_unittest'); - $this->InvokeNonPublicMethod("Combodo\iTop\Application\Status\Status", "StatusStartup", $oStatus, [$oConfigWrong]); + $oConfigWrong = new Config(ITOP_DEFAULT_CONFIG_FILE); + $oConfigWrong->Set('db_pwd', $oConfigWrong->Get('db_pwd').'_unittest'); + $this->InvokeNonPublicMethod(Status::class, "StatusStartup", $oStatus, [$oConfigWrong]); } /**