From 4f1f144c5165ae68b0eca12ae52a9269f787b1a9 Mon Sep 17 00:00:00 2001 From: Molkobain Date: Wed, 17 Dec 2025 22:04:49 +0100 Subject: [PATCH] =?UTF-8?q?N=C2=B06644=20-=20PHP=20Static=20Analysis:=20Up?= =?UTF-8?q?date=20configuration=20to:=20=20-=20Ignore=20compiled=20folders?= =?UTF-8?q?=20other=20than=20"env-production"=20=20-=20Ignore=20Lempar.php?= =?UTF-8?q?=20as=20its=20content=20isn't=20valid=20PHP=20and=20it=20won't?= =?UTF-8?q?=20be=20included=20in=20the=20baseline?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../php-static-analysis/config/base.dist.neon | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/tests/php-static-analysis/config/base.dist.neon b/tests/php-static-analysis/config/base.dist.neon index 804c6f089..827e7022f 100644 --- a/tests/php-static-analysis/config/base.dist.neon +++ b/tests/php-static-analysis/config/base.dist.neon @@ -5,8 +5,8 @@ includes: parameters: level: 0 - #phpVersion: null # Explicitly commented as we rather use the detected version from the above include (`php-includes/target-php-version.php`) - editorUrl: 'phpstorm://open?file=%%file%%&line=%%line%%' # Open in PHPStorm asit is Combodo's default IDE + #phpVersion: null # Explicitly commented as we rather use the detected version from the above include (`php-includes/target-php-version.php`) + editorUrl: 'phpstorm://open?file=%%file%%&line=%%line%%' # Open in PHPStorm as it's Combodo's default IDE bootstrapFiles: - ../../../approot.inc.php - ../../../bootstrap.inc.php @@ -22,11 +22,19 @@ parameters: - ../../../lib # Irrelevant as we only want to analyze our codebase - ../../../node_modules # Irrelevant as we only want to analyze our codebase analyseAndScan: - #- ../../../data # Left and commented on purpose to show that we want to analyse the generated cache files - # Note 1: We can analyse these folders as if a PHP file requires another PHP element declared in an XML file, it won't find it. So we rely only on `env-production` + # This file generates "unignorable errors" for the baseline due to its format, so we don't have any other choice than to exclude it. + # But mind that it will prevent PHPStan from warning us about PHP syntax errors in this file. + - ../../../core/oql/build/PHP/Lempar.php + + #- ../../../data # Left and commented on purpose to show that we want to analyse the generated cache files + + # Note 1: We can't analyse these folders as if a PHP file requires another PHP element declared in an XML file, it won't find it. So we rely only on `env-production` # Note 2: Only the options selected during the setup will be analysed correctly in `env-production`. For unselected options, we still want to ignore them during the analysis as they would only give a false sentiment of security as their XML PHP classes / snippets / etc would not be tested. - ../../../data/production-modules # Irrelevent as it will already be in `env-production` (for local run only, not useful in the CI) - - ../../../datamodels # Irrelevent as it will already be in `env-production` - - ../../../extensions # Irrelevent as it will already be in `env-production` (for local run only, not useful in the CI) - - ../../../tests # Exclude tests for now - - ../../../toolkit # Exlclude toolkit for now + - ../../../datamodels # Irrelevent as it will already be in `env-production` + - ../../../extensions # Irrelevent as it will already be in `env-production` (for local run only, not useful in the CI) + - ../../../env-php-unit-tests # Irrelevant as it will either already be in `env-production` or might be desynchronized from `env-production` + - ../../../env-toolkit # Irrelevent as it will either already be in `env-production` or might be desynchronized from `env-production` (for local run only, not useful in the CI) + + - ../../../tests # Exclude tests for now + - ../../../toolkit # Exlclude toolkit for now