From 485262ec0a0919749496dcc508d66b04eec69d89 Mon Sep 17 00:00:00 2001
From: Molkobain <lajarige.guillaume@free.fr>
Date: Sat, 12 Jun 2021 11:32:42 +0200
Subject: [PATCH] Accessibility: Add missing alt attribute on decorative images
 - Quick create - Global search - Breadcrumbs

---
 js/components/breadcrumbs.js                             | 3 ++-
 templates/base/components/global-search/layout.html.twig | 3 ++-
 templates/base/components/quick-create/layout.html.twig  | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/js/components/breadcrumbs.js b/js/components/breadcrumbs.js
index 2ea333e6c..6255a74f8 100644
--- a/js/components/breadcrumbs.js
+++ b/js/components/breadcrumbs.js
@@ -84,7 +84,8 @@ $(function()
                         }
                         else if (oEntry['icon'].length > 0)
                         {
-                            sIconSpec = '<span class="ibo-breadcrumbs--item-icon"><img src="'+oEntry['icon']+'"/></span>';
+	                        // Mind the empty "alt" attribute https://www.w3.org/WAI/tutorials/images/decorative/
+	                        sIconSpec = '<span class="ibo-breadcrumbs--item-icon"><img src="'+oEntry['icon']+'" alt=""/></span>';
                         }
 
 						var sTitle = oEntry['description'],
diff --git a/templates/base/components/global-search/layout.html.twig b/templates/base/components/global-search/layout.html.twig
index b5c2e8158..f98666076 100644
--- a/templates/base/components/global-search/layout.html.twig
+++ b/templates/base/components/global-search/layout.html.twig
@@ -24,7 +24,8 @@
 					{% for aQuery in oUIBlock.GetLastQueries() %}
 						<a href="{{ aQuery.target_url }}" class="ibo-global-search--compartment-element" data-role="ibo-global-search--compartment-element" data-query-raw="{{ aQuery.query }}" title="{{ aQuery.query }}">
 							{% if aQuery.icon_url is defined %}
-								<img src="{{ aQuery.icon_url}}" class="ibo-global-search--compartment-element-image">
+                                {# Mind the empty "alt" attribute https://www.w3.org/WAI/tutorials/images/decorative/ #}
+								<img src="{{ aQuery.icon_url}}" alt="" class="ibo-global-search--compartment-element-image">
 							{% endif %}
 							{{ aQuery.label_html|raw }}
 						</a>
diff --git a/templates/base/components/quick-create/layout.html.twig b/templates/base/components/quick-create/layout.html.twig
index 92261661b..4528ed447 100644
--- a/templates/base/components/quick-create/layout.html.twig
+++ b/templates/base/components/quick-create/layout.html.twig
@@ -28,7 +28,8 @@
 					{% for aClass in oUIBlock.GetLastClasses() %}
 						<a href="{{ aClass.target_url }}" class="ibo-quick-create--compartment-element" data-role="ibo-quick-create--compartment-element" data-class-code="{{ aQuery.class }}">
 							{% if aClass.icon_url is defined %}
-								<img src="{{ aClass.icon_url}}" class="ibo-quick-create--compartment-element-image">
+                                {# Mind the empty "alt" attribute https://www.w3.org/WAI/tutorials/images/decorative/ #}
+                                <img src="{{ aClass.icon_url}}" alt="" class="ibo-quick-create--compartment-element-image">
 							{% endif %}
 							{{ aClass.label_html|raw }}
 						</a>