From 46e7bbe2c8e66b97ca1390574360c2ca9673391d Mon Sep 17 00:00:00 2001
From: Denis Flaven <denis.flaven@combodo.com>
Date: Tue, 12 Apr 2011 09:37:52 +0000
Subject: [PATCH] Bug fix: prevent (infinite) recursion when building search
 form with external keys, that point to search form with external keys, etc...
 Now support nested search dialogs properly...

SVN:trunk[1210]
---
 application/ajaxwebpage.class.inc.php     |  2 +-
 application/ui.extkeywidget.class.inc.php | 25 +++++++++++++----------
 css/light-grey.css                        |  3 +++
 pages/ajax.render.php                     | 14 +++++++++++++
 4 files changed, 32 insertions(+), 12 deletions(-)

diff --git a/application/ajaxwebpage.class.inc.php b/application/ajaxwebpage.class.inc.php
index cd139dd40..3e43244dc 100644
--- a/application/ajaxwebpage.class.inc.php
+++ b/application/ajaxwebpage.class.inc.php
@@ -166,7 +166,7 @@ EOF
         $s_captured_output = ob_get_contents();
         ob_end_clean();
         echo $this->s_content;
-        echo $this->s_deferred_content;
+        //echo $this->s_deferred_content;
         if (count($this->a_scripts) > 0)
         {
             echo "<script type=\"text/javascript\">\n";
diff --git a/application/ui.extkeywidget.class.inc.php b/application/ui.extkeywidget.class.inc.php
index 71c75d0bf..81eaf5ce4 100644
--- a/application/ui.extkeywidget.class.inc.php
+++ b/application/ui.extkeywidget.class.inc.php
@@ -175,7 +175,6 @@ EOF
 			$sHTMLValue .= "<input type=\"hidden\" id=\"$this->iId\" name=\"{$sAttrFieldPrefix}{$this->sFieldPrefix}{$this->sAttCode}{$this->sNameSuffix}\" value=\"$this->value\" />\n";
 	
 			// Scripts to start the autocomplete and bind some events to it
-			$sDialogTitle = addslashes($this->sTitle);
 			$oPage->add_ready_script(
 <<<EOF
 		oACWidget_{$this->iId} = new ExtKeyWidget('{$this->iId}', '{$this->sClass}', '{$this->sAttCode}', '{$this->sNameSuffix}', $sSelectMode, $sWizHelper);
@@ -184,11 +183,10 @@ EOF
 		$('#label_$this->iId').blur(function() { $(this).search(); } );
 		$('#label_$this->iId').result( function(event, data, formatted) { OnAutoComplete('{$this->iId}', event, data, formatted); } );
 		$('#$this->iId').bind('update', function() { oACWidget_{$this->iId}.Update(); } );
-		$('#ac_dlg_$this->iId').dialog({ width: $(window).width()*0.8, height: $(window).height()*0.8, autoOpen: false, modal: true, title: '$sDialogTitle', resizeStop: oACWidget_{$this->iId}.UpdateSizes, close: oACWidget_{$this->iId}.OnClose });
-
 EOF
 );
-			$oPage->add_at_the_end($this->GetSearchDialog($oPage)); // To prevent adding forms inside the main form
+			//$oPage->add_at_the_end($this->GetSearchDialog($oPage)); // To prevent adding forms inside the main form
+			$oPage->add_at_the_end('<div id="ac_dlg_'.$this->iId.'"></div>'); // The place where to download the search dialog is outside of the main form (to prevent nested forms)
 
 		}
 		if ($bCreate)
@@ -201,9 +199,9 @@ EOF
 		return $sHTMLValue;
 	}
 	
-	protected function GetSearchDialog(WebPage $oPage)
+	public function GetSearchDialog(WebPage $oPage)
 	{
-		$sHTML = '<div id="ac_dlg_'.$this->iId.'"><div class="wizContainer" style="vertical-align:top;"><div id="dc_'.$this->iId.'">';
+		$sHTML = '<div class="wizContainer" style="vertical-align:top;"><div id="dc_'.$this->iId.'">';
 
 		$oFilter = new DBObjectSearch($this->sTargetClass);
 		$oSet = new CMDBObjectSet($oFilter);
@@ -216,12 +214,17 @@ EOF
 		$sHTML .= "<input type=\"button\" id=\"btn_cancel_{$this->iId}\" value=\"".Dict::S('UI:Button:Cancel')."\" onClick=\"$('#ac_dlg_{$this->iId}').dialog('close');\">&nbsp;&nbsp;";
 		$sHTML .= "<input type=\"button\" id=\"btn_ok_{$this->iId}\" value=\"".Dict::S('UI:Button:Ok')."\"  onClick=\"oACWidget_{$this->iId}.DoOk();\">";
 		$sHTML .= "</form>\n";
-		$sHTML .= '</div></div></div>';
+		$sHTML .= '</div></div>';
 
-		$oPage->add_ready_script("$('#fs_{$this->iId}').bind('submit.uiAutocomplete', oACWidget_{$this->iId}.DoSearchObjects);");
-		$oPage->add_ready_script("$('#dc_{$this->iId}').resize(oACWidget_{$this->iId}.UpdateSizes);");
-
-		return $sHTML;
+		$sDialogTitle = addslashes($this->sTitle);
+		$oPage->add_ready_script(
+<<<EOF
+		$('#ac_dlg_{$this->iId}').dialog({ width: $(window).width()*0.8, height: $(window).height()*0.8, autoOpen: false, modal: true, title: '$sDialogTitle', resizeStop: oACWidget_{$this->iId}.UpdateSizes, close: oACWidget_{$this->iId}.OnClose });
+		$('#fs_{$this->iId}').bind('submit.uiAutocomplete', oACWidget_{$this->iId}.DoSearchObjects);
+		$('#dc_{$this->iId}').resize(oACWidget_{$this->iId}.UpdateSizes);
+EOF
+);
+		$oPage->add($sHTML);
 	}
 
 	/**
diff --git a/css/light-grey.css b/css/light-grey.css
index 40f1557f3..31937d453 100644
--- a/css/light-grey.css
+++ b/css/light-grey.css
@@ -1045,4 +1045,7 @@ fieldset table.details>tbody>tr>td {
 	padding-top: 3px;
 	background: transparent;
 	border: 0;
+}
+.ac_dlg_loading {
+	background: white url('../images/indicator.gif') right center no-repeat;
 }
\ No newline at end of file
diff --git a/pages/ajax.render.php b/pages/ajax.render.php
index a5d0cd664..78ad2e5ce 100644
--- a/pages/ajax.render.php
+++ b/pages/ajax.render.php
@@ -96,6 +96,20 @@ try
 		$oWidget->SearchObjectsToSelect($oPage, $sTargetClass);	
 		break;
 	
+		// ui.extkeywidget
+		case 'objectSearchForm':
+		$sTargetClass = utils::ReadParam('sRemoteClass', '');
+		$sAttCode = utils::ReadParam('sAttCode', '');
+		$iInputId = utils::ReadParam('iInputId', '');
+		$sSuffix = utils::ReadParam('sSuffix', '');
+		$sValue = utils::ReadParam('sValue', '');
+		//$oWizardHelper = WizardHelper::FromJSON($sJson);
+		//$oObj = $oWizardHelper->GetTargetObject();
+		$aAllowedValues = MetaModel::GetAllowedValues_att($sClass, $sAttCode, array() /*array('this' => $oObj)*/);
+		$oWidget = new UIExtKeyWidget($sAttCode, $sClass, '', $aAllowedValues, $sValue, $iInputId, false, $sSuffix, '');
+		$oWidget->GetSearchDialog($oPage);
+		break;
+
 		// ui.extkeywidget
 		case 'objectCreationForm':
 		$sTargetClass = utils::ReadParam('sRemoteClass', '');