diff --git a/datamodels/2.x/itop-backup/check-backup.php b/datamodels/2.x/itop-backup/check-backup.php index 2af5a7375a..f2a27dab46 100644 --- a/datamodels/2.x/itop-backup/check-backup.php +++ b/datamodels/2.x/itop-backup/check-backup.php @@ -214,54 +214,54 @@ catch(Exception $e) $sZipArchiveFile = MakeArchiveFileName().'.tar.gz'; echo date('Y-m-d H:i:s')." - Checking file: $sZipArchiveFile\n"; -if (file_exists($sZipArchiveFile)) +if (!file_exists($sZipArchiveFile)) { - if ($aStat = stat($sZipArchiveFile)) - { - $iSize = (int) $aStat['size']; - $iMIN = utils::ReadParam('check_size_min', 0); - if ($iSize > $iMIN) - { - echo "Found the archive\n"; - $sOldArchiveFile = MakeArchiveFileName(time() - 86400).'.tar.gz'; // yesterday's archive - if (file_exists($sOldArchiveFile)) - { - if ($aOldStat = stat($sOldArchiveFile)) - { - echo "Comparing its size with older file: $sOldArchiveFile\n"; - $iOldSize = (int) $aOldStat['size']; - $fVariationPercent = 100 * ($iSize - $iOldSize) / $iOldSize; - $sVariation = round($fVariationPercent, 2)." percent(s)"; + RaiseAlarm("Missing backup file '$sZipArchiveFile'"); - $iREDUCTIONMAX = utils::ReadParam('check_size_reduction_max'); - if ($fVariationPercent < -$iREDUCTIONMAX) - { - RaiseAlarm("Backup file '$sZipArchiveFile' changed by $sVariation, expecting a reduction limited to $iREDUCTIONMAX percents of the original size"); - } - elseif ($fVariationPercent < 0) - { - echo "Size variation: $sVariation (the maximum allowed reduction is $iREDUCTIONMAX) \n"; - } - else - { - echo "The archive grew by: $sVariation\n"; - } - } - } + return; +} + +$aStat = stat($sZipArchiveFile); +if (!$aStat) +{ + RaiseAlarm("Failed to stat backup file '$sZipArchiveFile'"); + + return; +} + +$iSize = (int)$aStat['size']; +$iMIN = utils::ReadParam('check_size_min', 0); +if ($iSize <= $iMIN) +{ + RaiseAlarm("Backup file '$sZipArchiveFile' too small (Found: $iSize, while expecting $iMIN bytes)"); + + return; +} + + +echo "Found the archive\n"; +$sOldArchiveFile = MakeArchiveFileName(time() - 86400).'.tar.gz'; // yesterday's archive +if (file_exists($sOldArchiveFile)) +{ + if ($aOldStat = stat($sOldArchiveFile)) + { + echo "Comparing its size with older file: $sOldArchiveFile\n"; + $iOldSize = (int)$aOldStat['size']; + $fVariationPercent = 100 * ($iSize - $iOldSize) / $iOldSize; + $sVariation = round($fVariationPercent, 2)." percent(s)"; + + $iREDUCTIONMAX = utils::ReadParam('check_size_reduction_max'); + if ($fVariationPercent < -$iREDUCTIONMAX) + { + RaiseAlarm("Backup file '$sZipArchiveFile' changed by $sVariation, expecting a reduction limited to $iREDUCTIONMAX percents of the original size"); + } + elseif ($fVariationPercent < 0) + { + echo "Size variation: $sVariation (the maximum allowed reduction is $iREDUCTIONMAX) \n"; } else { - RaiseAlarm("Backup file '$sZipArchiveFile' too small (Found: $iSize, while expecting $iMIN bytes)"); + echo "The archive grew by: $sVariation\n"; } } - else - { - RaiseAlarm("Failed to stat backup file '$sZipArchiveFile'"); - } } -else -{ - RaiseAlarm("Missing backup file '$sZipArchiveFile'"); -} - -?>