composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 11:08:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°931: Limit the number of tags in the widget

Browse Source
This commit is contained in:
Eric
2018-09-20 15:15:25 +02:00
parent 38278f3432
commit 398d1aa820
7 changed files with 111 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
test/core/TagSetFieldDataTest.php
View File

@@ -185,16 +185,37 @@ class TagSetFieldDataTest extends ItopDataTestCase
}
/**
* Test that tag code cannot be modified
* @expectedException \CoreException
* Test that tag code cannot be modified if used
*
* @throws \CoreException
* @throws \CoreUnexpectedValue
* @throws \Exception
*/
public function testUpdateCode()
{
$oTagData = $this->CreateTagData(TAG_CLASS, TAG_ATTCODE, 'tag1', 'First');
$oTagData->Set('code', 'tag2');
$oTagData->DBWrite();
//Use it
$oTicket = $this->CreateTicket(1);
$oTicket->Set(TAG_ATTCODE, 'tag2');
$oTicket->DBWrite();
// Try to change the code of the tag, must complain !
try
{
$oTagData->Set('code', 'tag1');
$oTagData->DBWrite();
} catch (\CoreException $e)
{
static::assertTrue(true);
return;
}
// Should not pass here
static::assertFalse(true);
}
/**
@@ -227,4 +248,38 @@ class TagSetFieldDataTest extends ItopDataTestCase
// Failed
static::assertFalse(true);
}
public function testMaxTagsAllowed()
{
/** @var \AttributeTagSet $oAttDef */
$oAttDef = \MetaModel::GetAttributeDef(TAG_CLASS, TAG_ATTCODE);
$iMaxTags = $oAttDef->GetTagMaxNb();
for ($i = 0; $i < $iMaxTags; $i++)
{
$sTagCode = 'MaxTag'.$i;
$this->CreateTagData(TAG_CLASS, TAG_ATTCODE, $sTagCode, $sTagCode);
}
$oTicket = $this->CreateTicket(1);
$this->debug("Max number of tags is $iMaxTags");
$sValue = '';
for ($i = 0; $i < ($iMaxTags + 1); $i++)
{
try
{
$sTagCode = 'MaxTag'.$i;
$sValue .= "$sTagCode ";
$oTicket->Set(TAG_ATTCODE, $sValue);
$oTicket->DBWrite();
} catch (\Exception $e)
{
// Should fail on the last iteration
static::assertEquals($iMaxTags, $i);
$this->debug("Setting (".($i+1).") tag(s) failed");
return;
}
$this->debug("Setting (".($i+1).") tag(s) worked");
}
static::assertFalse(true);
}
}