From 37de3527eca6bb6026ef174a61ba9bd9306ee6c3 Mon Sep 17 00:00:00 2001
From: jf-cbd <jf-cbd@users.noreply.github.com>
Date: Wed, 10 Jun 2026 12:13:52 +0200
Subject: [PATCH] Add more unit tests

---
 .../Users/ITopUserCountingRepositoryTest.php  | 48 ++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/tests/php-unit-tests/unitary-tests/sources/Users/ITopUserCountingRepositoryTest.php b/tests/php-unit-tests/unitary-tests/sources/Users/ITopUserCountingRepositoryTest.php
index 71cda244d..21a4b7429 100644
--- a/tests/php-unit-tests/unitary-tests/sources/Users/ITopUserCountingRepositoryTest.php
+++ b/tests/php-unit-tests/unitary-tests/sources/Users/ITopUserCountingRepositoryTest.php
@@ -174,11 +174,57 @@ class ITopUserCountingRepositoryTest extends ItopDataTestCase
 		$aApplicationUsers = $oITopUserRepository->GetApplicationUsers();
 		$aBusinessPartnerUsers = $oITopUserRepository->GetBusinessPartnerUsers();
 
-		$aCountedUsers = array_merge($aConsoleUsers, $aPortalUsers, $aDisabledUsers, $aReadOnlyUsers, $aApplicationUsers);
+		$aCountedUsers = array_merge($aConsoleUsers, $aPortalUsers, $aDisabledUsers, $aReadOnlyUsers, $aApplicationUsers, $aBusinessPartnerUsers);
 
 		foreach ($aCountedUsers as $oUser) {
 			$this->assertInstanceOf(User::class, $oUser);
 		}
+	}
 
+	/**
+	 * @param array $aProfilesList
+	 * @param $sExpectedCategorie
+	 *
+	 * @return void
+	 * @throws \ArchivedObjectException
+	 * @throws \CoreException
+	 * @throws \CoreUnexpectedValue
+	 * @throws \DictExceptionMissingString
+	 * @throws \MySQLException
+	 * @dataProvider RealUseCasesDataProvider
+	 */
+	public function testRealUseCases(array $aProfilesList, $sExpectedCategorie)
+	{
+		$iUser = $this->GivenUserInDB('<_ç"éue"ç_u', $aProfilesList, false);
+		$oUser = \MetaModel::GetObject('User', $iUser);
+		$oITopUserRepository = new ITopUserCountingRepository();
+		$aUsers = match ($sExpectedCategorie) {
+			'console' => $oITopUserRepository->GetConsoleUsers(),
+			'readonly' => $oITopUserRepository->GetReadOnlyUsers(),
+			'disabled' => $oITopUserRepository->GetDisabledUsers(),
+			'portal' => $oITopUserRepository->GetPortalUsers(),
+			'application' => $oITopUserRepository->GetApplicationUsers(),
+			'businesspartner' => $oITopUserRepository->GetBusinessPartnerUsers(),
+			default => throw new \InvalidArgumentException(sprintf('Unexpected category %s', $sExpectedCategorie)),
+		};
+
+		$bUserInCorrectCategory = false;
+		foreach ($aUsers as $oUserInCategory) {
+			if ($oUserInCategory->GetKey() === $oUser->GetKey()) {
+				$bUserInCorrectCategory = true;
+			}
+		}
+		$this->assertTrue($bUserInCorrectCategory, 'User with profiles '.implode(', ', $aProfilesList).' should be counted as '.$sExpectedCategorie.' user');
+	}
+
+	public function RealUseCasesDataProvider()
+	{
+		return [
+			[['Support Agent', 'Configuration ReadOnly'], 'console'],
+			[['Configuration ReadOnly', 'Service Catalog ReadOnly'], 'readonly'],
+			[['Portal user', 'Service Catalog ReadOnly'], 'portal'],
+			[['Support Agent', 'Portal user'], 'portal'],
+			[['Configuration Manager', 'Ticket ReadOnly'], 'console'],
+		];
 	}
 }