From 35e58f8cd20b526b673fb154b64ce1697ef39e9b Mon Sep 17 00:00:00 2001 From: Romain Quetiez Date: Tue, 26 May 2015 11:44:12 +0000 Subject: [PATCH] Make it possible to overload RestUtils (static methods called with static:: instead of self::) - iTop NOW REQUIRES PHP 5.3: we have verified, there are very installations of iTop made on PHP 5.2. It is worth to note that PHP 5.3 is already end of life (5.4 will become end of life in 8 months) SVN:trunk[3584] --- application/applicationextension.inc.php | 16 ++++++++-------- setup/setuputils.class.inc.php | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/application/applicationextension.inc.php b/application/applicationextension.inc.php index c8567d8a5..63655d79a 100644 --- a/application/applicationextension.inc.php +++ b/application/applicationextension.inc.php @@ -1,5 +1,5 @@ $value) { - $realValue = self::MakeValue($sClass, $sAttCode, $value); + $realValue = static::MakeValue($sClass, $sAttCode, $value); $oSearch->AddCondition($sAttCode, $realValue, '='); if (is_object($value) || is_array($value)) { @@ -818,7 +818,7 @@ class RestUtils { if (is_object($key)) { - $res = self::FindObjectFromCriteria($sClass, $key); + $res = static::FindObjectFromCriteria($sClass, $key); } elseif (is_numeric($key)) { @@ -882,7 +882,7 @@ class RestUtils $oSearch = new DBObjectSearch($sClass); foreach ($key as $sAttCode => $value) { - $realValue = self::MakeValue($sClass, $sAttCode, $value); + $realValue = static::MakeValue($sClass, $sAttCode, $value); $oSearch->AddCondition($sAttCode, $realValue, '='); } } @@ -926,7 +926,7 @@ class RestUtils $oAttDef = MetaModel::GetAttributeDef($sClass, $sAttCode); if ($oAttDef instanceof AttributeExternalKey) { - $oExtKeyObject = self::FindObjectFromKey($oAttDef->GetTargetClass(), $value, true /* allow null */); + $oExtKeyObject = static::FindObjectFromKey($oAttDef->GetTargetClass(), $value, true /* allow null */); $value = ($oExtKeyObject != null) ? $oExtKeyObject->GetKey() : 0; } elseif ($oAttDef instanceof AttributeLinkedSet) @@ -939,7 +939,7 @@ class RestUtils $aLinks = array(); foreach($value as $oValues) { - $oLnk = self::MakeObjectFromFields($sLnkClass, $oValues); + $oLnk = static::MakeObjectFromFields($sLnkClass, $oValues); $aLinks[] = $oLnk; } $value = DBObjectSet::FromArray($sLnkClass, $aLinks); @@ -970,7 +970,7 @@ class RestUtils $oObject = MetaModel::NewObject($sClass); foreach ($aFields as $sAttCode => $value) { - $realValue = self::MakeValue($sClass, $sAttCode, $value); + $realValue = static::MakeValue($sClass, $sAttCode, $value); try { $oObject->Set($sAttCode, $realValue); @@ -997,7 +997,7 @@ class RestUtils $sClass = get_class($oObject); foreach ($aFields as $sAttCode => $value) { - $realValue = self::MakeValue($sClass, $sAttCode, $value); + $realValue = static::MakeValue($sClass, $sAttCode, $value); try { $oObject->Set($sAttCode, $realValue); diff --git a/setup/setuputils.class.inc.php b/setup/setuputils.class.inc.php index 5bd7c08b6..15d752d32 100644 --- a/setup/setuputils.class.inc.php +++ b/setup/setuputils.class.inc.php @@ -50,7 +50,7 @@ class CheckResult class SetupUtils { - const PHP_MIN_VERSION = '5.2.0'; + const PHP_MIN_VERSION = '5.3.0'; const MYSQL_MIN_VERSION = '5.0.0'; const MIN_MEMORY_LIMIT = 33554432; // = 32*1024*1024 Beware: Computations are not allowed in defining constants const SUHOSIN_GET_MAX_VALUE_LENGTH = 2048;