composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-25 11:38:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°3526 - Clean up pass on UIBlocks

Browse Source 
- Move UIBlock::ENUM_BLOCK_FILES_TYPE_XXX to iUIBlock
- Add PHPDoc
- Remove Object return type hint on overloadable methods
- Add scalar return type hint
- Add type hint on parameters
This commit is contained in:
Molkobain
2021-11-14 21:22:04 +01:00
parent a9b30e160f
commit 3598da8808
45 changed files with 353 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
sources/application/UI/Base/Layout/ActivityPanel/ActivityPanel.php
View File

@@ -295,7 +295,7 @@ class ActivityPanel extends UIBlock
*
* @return ActivityEntry[]
*/
public function GetEntries()
public function GetEntries(): array
{
if ($this->bAreEntriesSorted === false)
{
@@ -311,7 +311,7 @@ class ActivityPanel extends UIBlock
*
* @return array
*/
public function GetGroupedEntries()
public function GetGroupedEntries(): array
{
$aGroupedEntries = [];
@@ -462,7 +462,7 @@ class ActivityPanel extends UIBlock
*
* @return bool
*/
public function HasEntries()
public function HasEntries(): bool
{
return !empty($this->aEntries);
}
@@ -518,7 +518,7 @@ class ActivityPanel extends UIBlock
*
* @return array
*/
public function GetCaseLogTabs()
public function GetCaseLogTabs(): array
{
return $this->aCaseLogs;
}
@@ -611,7 +611,7 @@ class ActivityPanel extends UIBlock
*
* @return bool
*/
public function HasCaseLogTab(string $sAttCode)
public function HasCaseLogTab(string $sAttCode): bool
{
return isset($this->aCaseLogs[$sAttCode]);
}
@@ -621,7 +621,7 @@ class ActivityPanel extends UIBlock
*
* @return bool
*/
public function HasCaseLogTabs()
public function HasCaseLogTabs(): bool
{
return !empty($this->aCaseLogs);
}
@@ -811,7 +811,7 @@ class ActivityPanel extends UIBlock
*
* @return string
*/
public function GetDateTimeFormatForJSWidget()
public function GetDateTimeFormatForJSWidget(): string
{
$oDateTimeFormat = AttributeDateTime::GetFormat();
@@ -848,7 +848,7 @@ class ActivityPanel extends UIBlock
/**
* @inheritdoc
*/
public function GetSubBlocks()
public function GetSubBlocks(): array
{
$aSubBlocks = array();