composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-28 13:08:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°3526 - Clean up pass on UIBlocks

Browse Source 
- Move UIBlock::ENUM_BLOCK_FILES_TYPE_XXX to iUIBlock
- Add PHPDoc
- Remove Object return type hint on overloadable methods
- Add scalar return type hint
- Add type hint on parameters
This commit is contained in:
Molkobain
2021-11-14 21:22:04 +01:00
parent a9b30e160f
commit 3598da8808
45 changed files with 353 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sources/application/UI/Base/Component/PopoverMenu/NewsroomMenu/NewsroomMenu.php
View File

@@ -61,7 +61,7 @@ class NewsroomMenu extends PopoverMenu
*
* @return false|string
*/
public function GetParamsAsJson()
public function GetParamsAsJson(): string
{
return json_encode($this->aParams);
}

6
sources/application/UI/Base/Component/PopoverMenu/PopoverMenu.php
View File

@@ -372,7 +372,7 @@ class PopoverMenu extends UIBlock
*
* @return bool
*/
public function HasSection(string $sId)
public function HasSection(string $sId): bool
{
return array_key_exists($sId, $this->aSections);
}
@@ -402,7 +402,7 @@ class PopoverMenu extends UIBlock
*
* @return array
*/
public function GetSections()
public function GetSections(): array
{
return $this->aSections;
}
@@ -520,7 +520,7 @@ class PopoverMenu extends UIBlock
/**
* @inheritDoc
*/
public function GetSubBlocks()
public function GetSubBlocks(): array
{
$aSubBlocks = [];

2
sources/application/UI/Base/Component/PopoverMenu/PopoverMenuItem/JsPopoverMenuItem.php
View File

@@ -57,7 +57,7 @@ class JsPopoverMenuItem extends PopoverMenuItem
* @inheritDoc
* @throws \Exception
*/
public function GetJsFilesUrlRecursively(bool $bAbsoluteUrl = false)
public function GetJsFilesUrlRecursively(bool $bAbsoluteUrl = false): array
{
$aJsFiles = array_merge(parent::GetJsFilesUrlRecursively($bAbsoluteUrl), $this->oPopupMenuItem->GetLinkedScripts());

2
sources/application/UI/Base/Component/PopoverMenu/PopoverMenuItem/PopoverMenuItem.php
View File

@@ -55,7 +55,7 @@ class PopoverMenuItem extends UIBlock
/**
* @inheritDoc
*/
protected function GenerateId()
protected function GenerateId(): string
{
return parent::GenerateId().'--'.utils::GetSafeId($this->oPopupMenuItem->GetUID());
}