composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-27 04:28:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°3526 - Clean up pass on UIBlocks

Browse Source 
- Move UIBlock::ENUM_BLOCK_FILES_TYPE_XXX to iUIBlock
- Add PHPDoc
- Remove Object return type hint on overloadable methods
- Add scalar return type hint
- Add type hint on parameters
This commit is contained in:
Molkobain
2021-11-14 21:22:04 +01:00
parent a9b30e160f
commit 3598da8808
45 changed files with 353 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
sources/application/UI/Base/Component/Button/Button.php
View File

@@ -110,7 +110,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetLabel()
public function GetLabel(): string
{
return $this->sLabel;
}
@@ -129,7 +129,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetTooltip()
public function GetTooltip(): string
{
return $this->sTooltip;
}
@@ -148,7 +148,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetIconClass()
public function GetIconClass(): string
{
return $this->sIconClass;
}
@@ -167,7 +167,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetActionType()
public function GetActionType(): string
{
return $this->sActionType;
}
@@ -187,7 +187,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetColor()
public function GetColor(): string
{
return $this->sColor;
}
@@ -206,7 +206,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetOnClickJsCode()
public function GetOnClickJsCode(): string
{
return $this->sOnClickJsCode;
}
@@ -226,7 +226,7 @@ class Button extends UIBlock
/**
* @return string
*/
public function GetJsCode()
public function GetJsCode(): string
{
return $this->sJsCode;
}
@@ -246,7 +246,7 @@ class Button extends UIBlock
/**
* @return bool
*/
public function IsDisabled()
public function IsDisabled(): bool
{
return $this->bIsDisabled;
}

12
sources/application/UI/Base/Component/Button/ButtonJS.php
View File

@@ -42,11 +42,11 @@ class ButtonJS extends Button
/** @var string DEFAULT_TYPE */
public const DEFAULT_TYPE = self::ENUM_TYPE_BUTTON;
/** @var string $sType The HTML type of the button (eg. 'submit', 'button', ...) */
/** @var string The HTML type of the button (eg. 'submit', 'button', ...) */
protected $sType;
/** @var string $sName The HTML name of the button, used by forms */
/** @var string The HTML name of the button, used by forms */
protected $sName;
/** @var string $sValue The HTML value of the button, used by forms */
/** @var string The HTML value of the button, used by forms */
protected $sValue;
/**
@@ -81,7 +81,7 @@ class ButtonJS extends Button
/**
* @return string
*/
public function GetType()
public function GetType(): string
{
return $this->sType;
}
@@ -100,7 +100,7 @@ class ButtonJS extends Button
/**
* @return string
*/
public function GetName()
public function GetName(): string
{
return $this->sName;
}
@@ -119,7 +119,7 @@ class ButtonJS extends Button
/**
* @return string
*/
public function GetValue()
public function GetValue(): string
{
return $this->sValue;
}

4
sources/application/UI/Base/Component/Button/ButtonURL.php
View File

@@ -45,9 +45,9 @@ class ButtonURL extends Button
public const DEFAULT_TARGET = self::ENUM_TARGET_SELF;
/** @var string $sURL */
/** @var string */
protected $sURL;
/** @var string $sTarget */
/** @var string */
protected $sTarget;
/**