From 2763b991429969447ebdef8d69d06acb4119ebee Mon Sep 17 00:00:00 2001
From: Eric <eric.espie@combodo.com>
Date: Thu, 25 Feb 2021 14:44:16 +0100
Subject: [PATCH] #1946 Fix Twig templates logging too much

---
 .../application/TwigBase/Twig/TwigHelper.php   | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/sources/application/TwigBase/Twig/TwigHelper.php b/sources/application/TwigBase/Twig/TwigHelper.php
index 9637d54d7..56834d3a8 100644
--- a/sources/application/TwigBase/Twig/TwigHelper.php
+++ b/sources/application/TwigBase/Twig/TwigHelper.php
@@ -47,19 +47,23 @@ class TwigHelper
 	{
 		$oTwig = self::GetTwigEnvironment($sViewPath);
 		$oPage->add(self::RenderTemplate($oTwig, $aParams, $sTemplateName, $sDefaultType));
-		$oPage->add_script(self::RenderTemplate($oTwig, $aParams, $sTemplateName, 'js'));
-		$oPage->add_ready_script(self::RenderTemplate($oTwig, $aParams, $sTemplateName, 'ready.js'));
+		$oPage->add_script(self::RenderTemplate($oTwig, $aParams, $sTemplateName, 'js', false));
+		$oPage->add_ready_script(self::RenderTemplate($oTwig, $aParams, $sTemplateName, 'ready.js',false));
 	}
 
 	/**
 	 * @param \Twig\Environment $oTwig
-	 * @param $aParams
-	 * @param $sName
-	 * @param $sTemplateFileExtension
+	 * @param array $aParams
+	 * @param string $sName
+	 * @param string $sTemplateFileExtension
+	 * @param bool $bLogMissingFile
 	 *
 	 * @return string
+	 * @throws \Twig\Error\LoaderError
+	 * @throws \Twig\Error\RuntimeError
+	 * @throws \Twig\Error\SyntaxError
 	 */
-	private static function RenderTemplate(Environment $oTwig, $aParams, $sName, $sTemplateFileExtension)
+	private static function RenderTemplate(Environment $oTwig, $aParams, $sName, $sTemplateFileExtension, $bLogMissingFile = true)
 	{
 		try
 		{
@@ -71,7 +75,7 @@ class TwigHelper
 			{
 				IssueLog::Error($e->getMessage());
 			}
-			else
+			elseif ($bLogMissingFile)
 			{
 				IssueLog::Debug($e->getMessage());
 			}