poc form SDK (extends to form)

sources/DI/Form/Builder/AttributeBuilder.php

@@ -0,0 +1,195 @@
+<?php
+
+namespace Combodo\iTop\DI\Form\Builder;
+
+use AttributeBoolean;
+use AttributeDate;
+use AttributeDateTime;
+use AttributeEmailAddress;
+use AttributeEnum;
+use AttributeExternalField;
+use AttributeExternalKey;
+use AttributeImage;
+use AttributeLinkedSet;
+use AttributePassword;
+use AttributePhoneNumber;
+use AttributeText;
+use Combodo\iTop\DI\Form\Type\Attribute\DocumentType;
+use Combodo\iTop\DI\Form\Type\Attribute\ExternalFieldType;
+use Combodo\iTop\DI\Form\Type\Attribute\ExternalKeyType;
+use Combodo\iTop\DI\Form\Type\Attribute\LinkSetType;
+use Combodo\iTop\DI\Services\ObjectService;
+use Combodo\iTop\Service\Links\LinkSetModel;
+use Exception;
+use MetaModel;
+use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
+use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
+use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
+use Symfony\Component\Form\Extension\Core\Type\DateType;
+use Symfony\Component\Form\Extension\Core\Type\EmailType;
+use Symfony\Component\Form\Extension\Core\Type\PasswordType;
+use Symfony\Component\Form\Extension\Core\Type\TelType;
+use Symfony\Component\Form\Extension\Core\Type\TextareaType;
+use Symfony\Component\Form\Extension\Core\Type\TextType;
+
+class AttributeBuilder
+{
+	/** @var \Combodo\iTop\DI\Services\ObjectService object service */
+	private ObjectService $oObjectService;
+
+	/**
+	 * Constructor.
+	 *
+	 * @param \Combodo\iTop\DI\Services\ObjectService $oObjectService
+	 */
+	public function __construct(ObjectService $oObjectService)
+	{
+		$this->oObjectService = $oObjectService;
+	}
+
+	/**
+	 * Map AttributeDefinition >> FormType
+	 *
+	 * @param string $sObjectClass
+	 * @param string $sCode
+	 * @param array|null $lockedAttributes
+	 *
+	 * @return array|null
+	 * @throws \CoreException
+	 */
+	public function createAttribute(string $sObjectClass, string $sCode, ?array $lockedAttributes) : ?array
+	{
+		// load attribute definition
+		try {
+			$oAttributeDefinition = MetaModel::GetAttributeDef($sObjectClass, $sCode);
+			$sLabel = $oAttributeDefinition->GetLabel();
+		}
+		catch(Exception $e){
+			return null;
+		}
+
+		// locked state
+		$bIsLocked = $lockedAttributes !== null && array_key_exists($sCode, $lockedAttributes);
+
+		// create global form type (default as text)
+		$aFormType = [
+			'type' => TextType::class,
+			'label' => $sLabel,
+			'options' => [
+				'required' => !$oAttributeDefinition->IsNullAllowed(),
+				'disabled' => !$oAttributeDefinition->IsWritable() || $bIsLocked,
+				'attr' => [
+					'data-att-code' => $sCode
+				],
+				'row_attr' => [
+					'data-block' => 'container'
+				],
+				'label_attr' => [
+					'class' => $bIsLocked ? 'locked' : ''
+				]
+			]
+		];
+
+		// register dependencies
+		if(count($oAttributeDefinition->GetPrerequisiteAttributes()) > 0){
+			$dependencies = implode(' ', $oAttributeDefinition->GetPrerequisiteAttributes());
+			$aFormType['options']['attr']['data-depends-on'] = $dependencies;
+			$aFormType['depends_on'] = $dependencies;
+		}
+
+		// inject corresponding configuration
+		if($oAttributeDefinition instanceof AttributeExternalKey){
+			$aFormType['type'] = ExternalKeyType::class;
+			$aFormType['options']['allow_target_creation'] = $oAttributeDefinition->AllowTargetCreation();
+			$aFormType['options']['object_class'] =  $oAttributeDefinition->GetTargetClass();
+			$aFormType['options']['att_code'] =  $oAttributeDefinition->GetCode();
+			try{
+				$oObjectsSet = MetaModel::GetAllowedValuesAsObjectSet($oAttributeDefinition->GetHostClass(), $oAttributeDefinition->GetCode(), []);
+				$aFormType['options']['choices'] = $this->oObjectService->ToChoices($oObjectsSet);
+			}
+			catch(Exception $e){
+
+			}
+		}
+		else if($oAttributeDefinition instanceof AttributeExternalField){
+			$aFormType['type'] = ExternalFieldType::class;
+			$bIsExternalKey = $oAttributeDefinition->IsExternalKey(EXTKEY_ABSOLUTE);
+			if($bIsExternalKey){
+				$aFormType['options']['is_external_key'] = true;
+				$aFormType['options']['object_class'] = $oAttributeDefinition->GetExtAttDef()->GetTargetClass();
+			}
+		}
+		else if($oAttributeDefinition instanceof AttributeEmailAddress){
+			$aFormType['type'] = EmailType::class;
+		}
+		else if($oAttributeDefinition instanceof AttributePassword){
+			$aFormType['type'] = PasswordType::class;
+		}
+		else if($oAttributeDefinition instanceof AttributePhoneNumber){
+			$aFormType['type'] = TelType::class;
+			$aFormType['options']['attr'] =  [
+				'pattern' => '\+[0-9]{2}\s[0-9]\s[0-9]{2}\s[0-9]{2}\s[0-9]{2}\s[0-9]{2}',
+				'placeholder' => '+-- - -- -- --'
+			];
+		}
+		else if($oAttributeDefinition instanceof AttributeBoolean){
+			$aFormType['type'] = CheckboxType::class;
+		}
+		else if($oAttributeDefinition instanceof AttributeEnum){
+			$aFormType['type'] = ChoiceType::class;
+			try{
+				$aOptions = array_flip($oAttributeDefinition->GetAllowedValues());
+			}
+			catch(Exception $e){
+				$aOptions = [];
+			}
+			$aFormType['options']['choices'] = $aOptions;
+		}
+		else if($oAttributeDefinition instanceof AttributeImage){
+			$aFormType['type'] = DocumentType::class;
+		}
+		else if($oAttributeDefinition instanceof AttributeLinkedSet){
+
+			$aFormType['type'] = LinkSetType::class;
+			$aFormType['options']['is_indirect'] = $oAttributeDefinition->IsIndirect();
+			$aFormType['options']['is_abstract'] = MetaModel::IsAbstract(LinkSetModel::GetTargetClass($oAttributeDefinition));
+			$aFormType['options']['target_class'] = LinkSetModel::GetTargetClass($oAttributeDefinition);
+			if($aFormType['options']['is_abstract']){
+				$aFormType['options']['object_classes'] = MetaModel::EnumChildClasses(LinkSetModel::GetTargetClass($oAttributeDefinition));
+			}
+			$aFormType['options']['entry_options'] = [
+				'object_class' => $oAttributeDefinition->GetLinkedClass(),
+				'data_class' => $oAttributeDefinition->GetLinkedClass(),
+				'is_link_set' => true,
+				'ext_key_to_me' => $oAttributeDefinition->GetExtKeyToMe(),
+				'z_list' => 'list',
+				'attr' => [
+					'class' => 'z_list_list'
+				]
+			];
+			$aFormType['options']['attr'] = [
+				'class' => 'link_set'
+			];
+			$aFormType['options']['label_attr'] = [
+				'class' => 'combodo-field-set-label'
+			];
+		}
+		else if($oAttributeDefinition instanceof AttributeText){
+			$aFormType['type'] = TextareaType::class;
+			$aFormType['options']['attr']['rows'] =  10;
+			$aFormType['options']['attr']['data-widget'] = 'text_widget';
+		}
+		else if($oAttributeDefinition instanceof AttributeDate){
+			$aFormType['type'] = DateType::class;
+			$aFormType['options']['input'] = 'string';
+		}
+		else if($oAttributeDefinition instanceof AttributeDateTime){
+			$aFormType['type'] = DateTimeType::class;
+			$aFormType['options']['input'] = 'string';
+			$aFormType['options']['widget'] = 'single_text';
+			$aFormType['options']['with_seconds'] = true;
+		}
+
+		return $aFormType;
+	}
+}

sources/DI/Form/Builder/LayoutBuilder.php

@@ -0,0 +1,79 @@
+<?php
+
+namespace Combodo\iTop\DI\Form\Builder;
+
+use Combodo\iTop\DI\Form\Type\Layout\ColumnType;
+use Combodo\iTop\DI\Form\Type\Layout\FieldSetType;
+use Combodo\iTop\DI\Form\Type\Layout\RowType;
+use Dict;
+
+class LayoutBuilder
+{
+	/**
+	 * createRow.
+	 *
+	 * @param $key
+	 * @param $columns
+	 *
+	 * @return array
+	 */
+	public function createRow($key, $columns) : array
+	{
+		return [
+			'type' => RowType::class,
+			'options' => [
+				'items' => $columns,
+				'label' => false,
+				'row_attr' => [
+					'data-block' => 'container'
+				]
+			]
+		];
+	}
+
+	/**
+	 * createColumn.
+	 *
+	 * @param $key
+	 * @param $item
+	 * @param $dataClass
+	 *
+	 * @return array
+	 */
+	public function createColumn($key, $items) : array
+	{
+		return [
+			'type' => ColumnType::class,
+			'options' => [
+				'items' => $items,
+				'label' => false,
+				'row_attr' => [
+					'data-block' => 'container'
+				]
+			]
+		];
+	}
+
+	/**
+	 * createFieldSet.
+	 *
+	 * @param $key
+	 * @param $item
+	 * @param $dataClass
+	 *
+	 * @return array
+	 */
+	public function createFieldSet($key, $items) : array
+	{
+		return [
+			'type' => FieldSetType::class,
+			'options' => [
+				'items' => $items,
+				'label' => Dict::S(substr($key, 9)),
+				'row_attr' => [
+					'data-block' => 'container'
+				]
+			]
+		];
+	}
+}

sources/DI/Form/Listener/IFormTypeOptionModifier.php

@@ -11,10 +11,12 @@ use DBObject;
 interface IFormTypeOptionModifier
 {
 	/**
-	 * @param array $aInitialOptions form type option
+	 * Return new form type options for the provided DB object.
+	 *
+	 * @param array $aInitialOptions initial form type options
 	 * @param DBObject $oObject iTop DB object
 	 *
-	 * @return array
+	 * @return array new form type options
 	 */
 	public function getNewOptions(array $aInitialOptions, DBObject $oObject) : array;
 }

sources/DI/Form/Listener/ObjectFormListener.php

@@ -36,7 +36,7 @@ class ObjectFormListener implements EventSubscriberInterface
 	 * When form is first initialized, it hasn't data set yet.
 	 * So we listen for form PRE_SET_DATA event to modify form with data.
 	 *
-	 * @param FormEvent $oEvent
+	 * @param FormEvent $oEvent form event
 	 *
 	 * @suppress-unused-warning
 	 */
@@ -50,7 +50,7 @@ class ObjectFormListener implements EventSubscriberInterface
 	 * Previous preSetData handling doesn't know about form submission data.
 	 * So, to allow us to use our DBObject for filters we need to update it before.
 	 *
-	 * @param FormEvent $oEvent
+	 * @param FormEvent $oEvent form event
 	 *
 	 * @suppress-unused-warning
 	 */
@@ -71,6 +71,7 @@ class ObjectFormListener implements EventSubscriberInterface
 	 *
 	 * We need to reset fields to take into account object values.
 	 * The form fields options can't be changed at this time.
+	 * All fields are reset to keep fields order.
 	 *
 	 * @param FormInterface $oForm
 	 * @param FormEvent $oEvent
@@ -113,6 +114,8 @@ class ObjectFormListener implements EventSubscriberInterface
 
 	/**
 	 * Handle posted data.
+	 * The data are the view data. We skipped data transformation !!
+	 * @todo handle data transformation
 	 *
 	 * @param FormInterface $form
 	 * @param DBObject $oDBObject

sources/DI/Form/Transformer/DocumentTransformer.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Combodo\iTop\DI\Form\Transformer;
+
+use ormDocument;
+use Symfony\Component\Form\DataTransformerInterface;
+
+/**
+ * Perform transformation between ormDocument and UploadedFile.
+ */
+class DocumentTransformer implements DataTransformerInterface
+{
+
+	/** @inheritdoc  */
+	public function transform($value)
+	{
+
+		return null;
+	}
+
+	/** @inheritdoc  */
+	public function reverseTransform($value)
+	{
+		if($value === null){
+			return null;
+		}
+
+		$doc_content = file_get_contents($value->getRealPath());
+		return new ormDocument($doc_content, $value->getClientMimeType(), $value->getRealPath());
+	}
+}

sources/DI/Form/Transformer/ExternalKeyTransformer.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace Combodo\iTop\DI\Form\Transformer;
+
+use Exception;
+use MetaModel;
+use Symfony\Component\Form\DataTransformerInterface;
+
+/**
+ * Transform external key ref to external key name representation.
+ */
+class ExternalKeyTransformer implements DataTransformerInterface
+{
+
+	/** @var string $sObjectClass */
+	private string $sObjectClass;
+
+	/**
+	 * @param string $sObjectClass
+	 */
+	public function __construct(string $sObjectClass)
+	{
+		$this->sObjectClass = $sObjectClass;
+	}
+
+	/** @inheritdoc  */
+	public function transform($value)
+	{
+		try{
+			return MetaModel::GetObject($this->sObjectClass, $value)->GetName();
+		}
+		catch(Exception $e){
+			return null;
+		}
+	}
+
+	/** @inheritdoc  */
+	public function reverseTransform($value)
+	{
+		return $value;
+	}
+}

sources/DI/Form/Type/Attribute/DocumentType.php

@@ -1,15 +1,14 @@
 <?php
 
-namespace Combodo\iTop\DI\Form\Type\Simple;
+namespace Combodo\iTop\DI\Form\Type\Attribute;
 
+use Combodo\iTop\DI\Form\Transformer\DocumentTransformer;
 use ormDocument;
 use Symfony\Component\Form\AbstractType;
-use Symfony\Component\Form\CallbackTransformer;
 use Symfony\Component\Form\Extension\Core\Type\FileType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\Form\FormView;
-use Symfony\Component\HttpFoundation\File\UploadedFile;
 
 /**
  * Example of type with data transformer.
@@ -23,23 +22,7 @@ class DocumentType extends AbstractType
 	{
 		parent::buildForm($builder, $options);
 
-		$builder->addModelTransformer(new CallbackTransformer(
-
-			// transform
-			function (?ormDocument $oDocument){
-				return null;
-			},
-
-			// reverse
-			function (?UploadedFile $oFileData){
-				if($oFileData === null){
-					return null;
-				}
-
-				$doc_content = file_get_contents($oFileData->getRealPath());
-				return new ormDocument($doc_content, $oFileData->getClientMimeType(), $oFileData->getRealPath());
-			},
-		));
+		$builder->addModelTransformer(new DocumentTransformer());
 	}
 
 	/** @inheritdoc  */
@@ -47,7 +30,7 @@ class DocumentType extends AbstractType
 	{
 		/** @var ormDocument $oOrmDocument */
 		$oOrmDocument = $form->getData();
-		$view->vars['data'] = 'data:image/' . $oOrmDocument->GetMimeType() . ';base64,' . base64_encode($oOrmDocument->GetData());;
+		$view->vars['data'] = 'data:image/' . $oOrmDocument->GetMimeType() . ';base64,' . base64_encode($oOrmDocument->GetData());
 		$view->vars['mime_type'] = $oOrmDocument->GetMimeType();
 		$view->vars['filename'] = $oOrmDocument->GetFileName();
 	}

sources/DI/Form/Type/Attribute/ExternalFieldType.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace Combodo\iTop\DI\Form\Type\Attribute;
+
+use Combodo\iTop\DI\Form\Transformer\ExternalKeyTransformer;
+use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\Extension\Core\Type\TextType;
+use Symfony\Component\Form\FormBuilderInterface;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+
+class ExternalFieldType extends AbstractType
+{
+
+	/** @inheritdoc  */
+	public function configureOptions(OptionsResolver $resolver): void
+	{
+		$resolver->setDefaults([
+			'object_class' => null,
+			'is_external_key' => false,
+		]);
+
+	}
+	/** @inheritdoc  */
+	public function buildForm(FormBuilderInterface $builder, array $options)
+	{
+		if($options['is_external_key']){
+			$builder->addViewTransformer(new ExternalKeyTransformer($options['object_class']));
+		}
+
+	}
+
+	/** @inheritdoc  */
+	public function getParent(): string
+	{
+		return TextType::class;
+	}
+
+}

sources/DI/Form/Type/Attribute/ExternalKeyType.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Combodo\iTop\DI\Form\Type\Simple;
+namespace Combodo\iTop\DI\Form\Type\Attribute;
 
 use Combodo\iTop\DI\Form\Listener\IFormTypeOptionModifier;
 use Combodo\iTop\DI\Services\ObjectService;
@@ -32,14 +32,10 @@ class ExternalKeyType extends AbstractType implements IFormTypeOptionModifier
 	public function configureOptions(OptionsResolver $resolver): void
 	{
 		$resolver->setDefaults([
-			'display_style' => 'list',
 			'allow_target_creation' => false,
 			'object_class' => null,
 			'att_code' => null,
 		]);
-
-		$resolver->setAllowedTypes('display_style', 'string');
-		$resolver->setAllowedValues('display_style', ['radio', 'radio_horizontal', 'radio_vertical', 'select', 'list']);
 	}
 
 	/** @inheritdoc  */
@@ -58,7 +54,8 @@ class ExternalKeyType extends AbstractType implements IFormTypeOptionModifier
 	public function getNewOptions(array $aInitialOptions, DBObject $oObject) : array
 	{
 		try{
-			$oObjectsSet = MetaModel::GetAllowedValuesAsObjectSet(get_class($oObject), $aInitialOptions['att_code'], ['this' => $oObject]);
+//			$iVal = $oObject->Get($aInitialOptions['att_code']); // because we can't list all items du to performance, we want to force current value to be present, even if it's not part of the result
+			$oObjectsSet = MetaModel::GetAllowedValuesAsObjectSet(get_class($oObject), $aInitialOptions['att_code'], ['this' => $oObject]/*, null, $iVal*/);
 			$aInitialOptions['choices'] = $this->oObjectService->ToChoices($oObjectsSet);
 		}
 		catch(Exception $e){

sources/DI/Form/Type/Attribute/LinkSetType.php

@@ -1,10 +1,9 @@
 <?php
 
-namespace Combodo\iTop\DI\Form\Type\Simple;
+namespace Combodo\iTop\DI\Form\Type\Attribute;
 
-use Combodo\iTop\DI\Form\Type\ObjectType;
+use Combodo\iTop\DI\Form\Type\Compound\ObjectType;
 use Combodo\iTop\DI\Services\ObjectPresentationService;
-use Combodo\iTop\DI\Services\ObjectService;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\CollectionType;
 use Symfony\Component\Form\FormInterface;
@@ -35,9 +34,11 @@ class LinkSetType extends AbstractType
 	{
 		$resolver->setDefaults([
 			'entry_type' => ObjectType::class,
-			'entry_options' => [
-				'object_class' => null
-			],
+			'is_indirect' => false,
+			'is_abstract' => false,
+			'object_classes' => null,
+			'target_class' => null,
+			'entry_options' => null,
 			'allow_add' => true,
 			'allow_delete' => true,
 		]);
@@ -53,6 +54,12 @@ class LinkSetType extends AbstractType
 	/** @inheritdoc  */
 	public function buildView(FormView $view, FormInterface $form, array $options): void
 	{
-		$view->vars['labels'] = $this->oObjectService->getFormPresentationLabels($options['entry_options']['object_class'], 'list', $options['entry_options']['ext_key_to_me']);;
+		$view->vars['labels'] = $this->oObjectService->getFormPresentationLabels($options['entry_options']['object_class'], 'list', $options['entry_options']['ext_key_to_me']);
+		$view->vars['object_class'] = $options['entry_options']['object_class'];
+		$view->vars['ext_key_to_me'] = $options['entry_options']['ext_key_to_me'];
+		$view->vars['target_class'] = $options['target_class'];
+		$view->vars['is_indirect'] = $options['is_indirect'];
+		$view->vars['is_abstract'] = $options['is_abstract'];
+		$view->vars['object_classes'] = $options['object_classes'];
 	}
 }

sources/DI/Form/Type/Compound/ConfigurationType.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Combodo\iTop\DI\Form\Type;
+namespace Combodo\iTop\DI\Form\Type\Compound;
 
 use Combodo\iTop\DI\Form\Type\Layout\FieldSetType;
 use MetaModel;
@@ -95,13 +95,13 @@ class ConfigurationType extends AbstractType
 	/**
 	 * Handle category.
 	 *
-	 * @param $aCategories
-	 * @param $aSettings
-	 * @param $builder
+	 * @param array $aCategories
+	 * @param array $aSettings
+	 * @param FormBuilderInterface $builder
 	 *
 	 * @return void
 	 */
-	private function handleCategories($aCategories, $aSettings, $builder)
+	private function handleCategories(array $aCategories, array $aSettings, FormBuilderInterface $builder)
 	{
 		// iterate throw categories...
 		foreach ($aCategories as $sKey => $sValue) {
@@ -145,12 +145,12 @@ class ConfigurationType extends AbstractType
 	 * Handle array of entries.
 	 *
 	 * @param array $aEntries
-	 * @param $aSettings
-	 * @param $builder
+	 * @param array $aSettings
+	 * @param FormBuilderInterface $builder
 	 *
 	 * @return void
 	 */
-	private function handleEntries(array $aEntries, $aSettings, $builder)
+	private function handleEntries(array $aEntries, array $aSettings, FormBuilderInterface $builder)
 	{
 		// iterate throw entries...
 		foreach ($aEntries as $sKey => $aValue){
@@ -168,12 +168,12 @@ class ConfigurationType extends AbstractType
 	/**
 	 * Return form type depending on settings definition.
 	 *
-	 * @param $aSettings
-	 * @param $sKey
+	 * @param array $aSettings
+	 * @param string $sKey
 	 *
 	 * @return string
 	 */
-	private function getFormType($aSettings, $sKey) : string{
+	private function getFormType(array $aSettings, string $sKey) : string{
 
 		if(!array_key_exists($sKey, $aSettings)){
 			return TextType::class;
@@ -190,13 +190,16 @@ class ConfigurationType extends AbstractType
 	}
 
 	/**
-	 * @param $aSettings
-	 * @param $sKey
-	 * @param $sTopic
+	 * Get parameter setting topic.
 	 *
-	 * @return string
+	 * @param array $aSettings
+	 * @param string $sKey
+	 * @param string $sTopic
+	 *
+	 * @return string|null
 	 */
-	private function getTopic($aSettings, $sKey, $sTopic) : ?string{
+	private function getTopic(array $aSettings, string $sKey, string $sTopic) : ?string
+	{
 
 		if(!array_key_exists($sKey, $aSettings)){
 			return null;

sources/DI/Form/Type/Compound/ObjectSingleAttributeType.php

@@ -1,9 +1,9 @@
 <?php
 
-namespace Combodo\iTop\DI\Form\Type;
+namespace Combodo\iTop\DI\Form\Type\Compound;
 
+use Combodo\iTop\DI\Form\Builder\AttributeBuilder;
 use Combodo\iTop\DI\Form\Listener\ObjectFormListener;
-use Combodo\iTop\DI\Services\ObjectPresentationService;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
@@ -17,19 +17,19 @@ class ObjectSingleAttributeType extends AbstractType
 	/** @var ObjectFormListener object form modifier */
 	private ObjectFormListener $oObjectFormModifier;
 
-	/** @var ObjectPresentationService object presentation service */
-	private ObjectPresentationService $objectPresentationService;
+	/** @var AttributeBuilder attribute builder */
+	private AttributeBuilder $oAttributeBuilder;
 
 	/**
 	 * Constructor.
 	 *
 	 * @param ObjectFormListener $oObjectFormModifier
-	 * @param ObjectPresentationService $objectPresentationService
+	 * @param AttributeBuilder $oAttributeBuilder
 	 */
-	public function __construct(ObjectFormListener $oObjectFormModifier, ObjectPresentationService $objectPresentationService)
+	public function __construct(ObjectFormListener $oObjectFormModifier, AttributeBuilder $oAttributeBuilder)
 	{
 		$this->oObjectFormModifier = $oObjectFormModifier;
-		$this->objectPresentationService = $objectPresentationService;
+		$this->oAttributeBuilder = $oAttributeBuilder;
 	}
 
 	/** @inheritdoc  */
@@ -41,11 +41,13 @@ class ObjectSingleAttributeType extends AbstractType
 		]);
 	}
 
-	/** @inheritdoc  */
+	/** @inheritdoc
+	 * @throws \CoreException
+	 */
 	public function buildForm(FormBuilderInterface $builder, array $options): void
 	{
 		// build form from options
-		$sFormType = $this->objectPresentationService->GetAttributeFormType($options['object_class'], $options['att_code']);
+		$sFormType = $this->oAttributeBuilder->createAttribute($options['object_class'], $options['att_code']);
 
 		// add form field
 		$builder->add($options['att_code'], $sFormType['type'], $sFormType['options']);

sources/DI/Form/Type/Compound/ObjectType.php

@@ -1,8 +1,10 @@
 <?php
 
-namespace Combodo\iTop\DI\Form\Type;
+namespace Combodo\iTop\DI\Form\Type\Compound;
 
 use cmdbAbstractObject;
+use Combodo\iTop\DI\Form\Builder\AttributeBuilder;
+use Combodo\iTop\DI\Form\Builder\LayoutBuilder;
 use Combodo\iTop\DI\Form\Listener\ObjectFormListener;
 use Combodo\iTop\DI\Services\ObjectPresentationService;
 use Symfony\Component\Form\AbstractType;
@@ -25,16 +27,26 @@ class ObjectType extends AbstractType
 	/** @var ObjectPresentationService object presentation service */
 	private ObjectPresentationService $objectPresentationService;
 
+	/** @var \Combodo\iTop\DI\Form\Builder\AttributeBuilder attribute builder */
+	private AttributeBuilder $oAttributeBuilder;
+
+	/** @var \Combodo\iTop\DI\Form\Builder\LayoutBuilder layout builder */
+	private LayoutBuilder $oLayoutBuilder;
+
 	/**
 	 * Constructor.
 	 *
 	 * @param ObjectFormListener $oObjectFormModifier
 	 * @param ObjectPresentationService $objectPresentationService
+	 * @param \Combodo\iTop\DI\Form\Builder\AttributeBuilder $oAttributeBuilder
+	 * @param \Combodo\iTop\DI\Form\Builder\LayoutBuilder $oLayoutBuilder
 	 */
-	public function __construct(ObjectFormListener $oObjectFormModifier, ObjectPresentationService $objectPresentationService)
+	public function __construct(ObjectFormListener $oObjectFormModifier, ObjectPresentationService $objectPresentationService, AttributeBuilder $oAttributeBuilder, LayoutBuilder $oLayoutBuilder)
 	{
 		$this->oObjectFormModifier = $oObjectFormModifier;
 		$this->objectPresentationService = $objectPresentationService;
+		$this->oAttributeBuilder = $oAttributeBuilder;
+		$this->oLayoutBuilder = $oLayoutBuilder;
 	}
 
 	/** @inheritdoc  */
@@ -48,24 +60,29 @@ class ObjectType extends AbstractType
 				'class' =>  'z_list_details'
 			],
 			'object_class' => null,
+			'locked_attributes' => null,
 			'data_class' => cmdbAbstractObject::class,
 		]);
 
 	}
 
-	/**
-	 * @inheritdoc
-	 * @throws \Exception
-	 */
+	/** @inheritdoc  */
 	public function buildForm(FormBuilderInterface $builder, array $options): void
 	{
 		// build form from presentation
-		$this->objectPresentationService->buildFormFromPresentation($options['object_class'], $options['z_list'], $options['is_link_set'], $options['ext_key_to_me'], $builder);
+		$this->objectPresentationService->buildFormFromPresentation(
+			$options['object_class'],
+			$options['z_list'],
+			$options['is_link_set'],
+			$options['ext_key_to_me'],
+			$options['locked_attributes'],
+			$builder);
 
 		// dynamic form handling
 		$builder->addEventSubscriber($this->oObjectFormModifier);
 	}
 
+	/** @inheritdoc  */
 	public function buildView(FormView $view, FormInterface $form, array $options)
 	{
 		parent::buildView($view, $form, $options);