From 118622493f2a3df4b3241c57bcd85832e1989c53 Mon Sep 17 00:00:00 2001 From: Stephen Abello Date: Wed, 10 Aug 2022 14:01:56 +0200 Subject: [PATCH 1/5] =?UTF-8?q?N=C2=B05050=20Revert=20entry=20deleted=20in?= =?UTF-8?q?=203b83d3f2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../dictionaries/es_cr.dict.itop-core-update.php | 1 + 1 file changed, 1 insertion(+) diff --git a/datamodels/2.x/itop-core-update/dictionaries/es_cr.dict.itop-core-update.php b/datamodels/2.x/itop-core-update/dictionaries/es_cr.dict.itop-core-update.php index 9b189a26d..51b596908 100644 --- a/datamodels/2.x/itop-core-update/dictionaries/es_cr.dict.itop-core-update.php +++ b/datamodels/2.x/itop-core-update/dictionaries/es_cr.dict.itop-core-update.php @@ -77,6 +77,7 @@ Dict::Add('ES CR', 'Spanish', 'Español, Castellano', array( 'iTopUpdate:UI:CanCoreUpdate:No' => 'La aplicación no puede ser actualizada: %1$s', 'iTopUpdate:UI:CanCoreUpdate:Warning' => 'Advertencia: la actualización de la aplicación puede fallar: %1$s', 'iTopUpdate:UI:CannotUpdateUseSetup' => 'Debe usar setup para actualizar la aplicación.
Algunos archivos modificados fueron detectados, una actualización parcial no puede ser realizada.', + 'iTopUpdate:UI:CheckInProgress' => 'Please wait during integrity check~~', // Setup Messages 'iTopUpdate:UI:SetupMessage:Ready' => 'Listo para empezar', From 3d593faad85fdd763418d4feb0c9e2ab8ce6cd54 Mon Sep 17 00:00:00 2001 From: Stephen Abello Date: Wed, 10 Aug 2022 14:02:46 +0200 Subject: [PATCH 2/5] Fix datatables semantic colors not using sematinc variables --- css/backoffice/vendors/_datatables.scss | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/css/backoffice/vendors/_datatables.scss b/css/backoffice/vendors/_datatables.scss index 0e957c950..bab02ea89 100644 --- a/css/backoffice/vendors/_datatables.scss +++ b/css/backoffice/vendors/_datatables.scss @@ -42,26 +42,26 @@ $ibo-vendors-datatables--row-highlight--first-cell--width: 3px !default; $ibo-vendors-datatables--row-highlight--colors:( 'red': ($ibo-color-red-100), - 'danger': ($ibo-color-red-200), + 'danger': ($ibo-color-danger-200), 'alert': ($ibo-color-red-200), 'orange': ($ibo-color-orange-100), - 'warning': ($ibo-color-orange-200), + 'warning': ($ibo-color-warning-200), 'blue': ($ibo-color-blue-200), - 'info': ($ibo-color-blue-200), + 'info': ($ibo-color-information-200), 'green': ($ibo-color-green-100), - 'success': ($ibo-color-green-200), + 'success': ($ibo-color-success-200), ) !default; $ibo-vendors-datatables--row-highlight--first-cell--colors:( 'red': ($ibo-color-red-300), - 'danger': ($ibo-color-red-400), + 'danger': ($ibo-color-danger-400), 'alert': ($ibo-color-red-400), 'orange': ($ibo-color-orange-300), - 'warning': ($ibo-color-orange-400), + 'warning': ($ibo-color-warning-400), 'blue': ($ibo-color-blue-400), - 'info': ($ibo-color-blue-400), + 'info': ($ibo-color-information-400), 'green': ($ibo-color-green-300), - 'success': ($ibo-color-green-300), + 'success': ($ibo-color-success-300), ) !default; .dataTables_paginate { From 77e9eaba00ef1436be961ee9ccbff48764e524ca Mon Sep 17 00:00:00 2001 From: Stephen Abello Date: Wed, 10 Aug 2022 14:03:48 +0200 Subject: [PATCH 3/5] Add highlighted rows to RenderAllUiBlocks --- .../Backoffice/RenderAllUiBlocks.php | 28 +++++++++++++++---- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/test/VisualTest/Backoffice/RenderAllUiBlocks.php b/test/VisualTest/Backoffice/RenderAllUiBlocks.php index 2e1f74495..b841a153b 100644 --- a/test/VisualTest/Backoffice/RenderAllUiBlocks.php +++ b/test/VisualTest/Backoffice/RenderAllUiBlocks.php @@ -402,11 +402,29 @@ $oPage->AddUiBlock(DataTableUIBlockFactory::MakeForStaticData('Static datatable' array( array( 'a' => 'A1', 'b' => 'B1', 'c' => 'C1', 'd' => 'D1' -),array( + ), array( 'a' => 'A2', 'b' => 'B2', 'c' => 'C2', 'd' => 'D2' -), - array( - 'a' => 'A3', 'b' => 'B3', 'c' => 'C3', 'd' => 'D3' - )))); + ), array( + 'a' => 'A3', 'b' => 'B3', 'c' => 'C3', 'd' => 'D3' + ), array( + 'a' => 'A4', 'b' => 'B4', 'c' => 'C4', 'd' => 'D4' + ),array( + '@class' => 'ibo-is-red','a' => 'A5', 'b' => 'B5', 'c' => 'C5', 'd' => 'D5' + ),array( + '@class' => 'ibo-is-danger','a' => 'A6', 'b' => 'B6', 'c' => 'C6', 'd' => 'D6' + ),array( + '@class' => 'ibo-is-orange','a' => 'A7', 'b' => 'B7', 'c' => 'C7', 'd' => 'D7' + ),array( + '@class' => 'ibo-is-warning','a' => 'A8', 'b' => 'B8', 'c' => 'C8', 'd' => 'D8' + ),array( + '@class' => 'ibo-is-blue','a' => 'A9', 'b' => 'B9', 'c' => 'C9', 'd' => 'D9' + ),array( + '@class' => 'ibo-is-info','a' => 'A10', 'b' => 'B10', 'c' => 'C10', 'd' => 'D10' + ),array( + '@class' => 'ibo-is-green','a' => 'A11', 'b' => 'B11', 'c' => 'C11', 'd' => 'D11' + ),array( + '@class' => 'ibo-is-success','a' => 'A12', 'b' => 'B12', 'c' => 'C12', 'd' => 'D12' + ), +))); $oPage->output(); From b43b2e97414aefeb726cb0a2bd40d85b2dea2d9e Mon Sep 17 00:00:00 2001 From: Stephen Abello Date: Wed, 10 Aug 2022 14:04:39 +0200 Subject: [PATCH 4/5] Remove padding between Dashlet/Preferences datatables and their parent panel --- application/displayblock.class.inc.php | 1 + pages/preferences.php | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/application/displayblock.class.inc.php b/application/displayblock.class.inc.php index 725b5cfb4..f76453ae0 100644 --- a/application/displayblock.class.inc.php +++ b/application/displayblock.class.inc.php @@ -1207,6 +1207,7 @@ JS $sTitle = Dict::Format($sFormat, $iTotalCount); $oBlock = PanelUIBlockFactory::MakeForClass($aExtraParams["panel_class"], $aExtraParams["panel_title"]); $oBlock->AddSubTitleBlock(new Html($sTitle)); + $oBlock->AddCSSClass('ibo-datatable-panel'); if(isset($aExtraParams["panel_icon"]) && strlen($aExtraParams["panel_icon"]) > 0){ $oBlock->SetIcon($aExtraParams["panel_icon"]); } diff --git a/pages/preferences.php b/pages/preferences.php index c251fac7b..b21b8fac1 100644 --- a/pages/preferences.php +++ b/pages/preferences.php @@ -140,7 +140,8 @@ JS ////////////////////////////////////////////////////////////////////////// $oFavoriteOrganizationsBlock = new Panel(Dict::S('UI:FavoriteOrganizations'), array(), 'grey', 'ibo-favorite-organizations'); - $oFavoriteOrganizationsBlock->AddHtml(Dict::S('UI:FavoriteOrganizations+')); + $oFavoriteOrganizationsBlock->SetSubTitle(Dict::S('UI:FavoriteOrganizations+')); + $oFavoriteOrganizationsBlock->AddCSSClass('ibo-datatable-panel'); $oFavoriteOrganizationsForm = new Form(); $oFavoriteOrganizationsBlock->AddSubBlock($oFavoriteOrganizationsForm); // Favorite organizations: the organizations listed in the drop-down menu @@ -194,6 +195,8 @@ JS ////////////////////////////////////////////////////////////////////////// $oShortcutsBlock = new BlockShortcuts(Dict::S('Menu:MyShortcuts'), array(), 'grey', 'ibo-shortcuts'); + $oShortcutsBlock->AddCSSClass('ibo-datatable-panel'); + $oShortcutsBlock->sIdShortcuts = 'shortcut_list'; $oShortcutsFilter = new DBObjectSearch('Shortcut'); $oShortcutsFilter->AddCondition('user_id', UserRights::GetUserId(), '='); From b3750e46cf1fb2145615e9e663adbe46a7403c3a Mon Sep 17 00:00:00 2001 From: Stephen Abello Date: Wed, 10 Aug 2022 14:07:06 +0200 Subject: [PATCH 5/5] Stylize datatables before widget is loaded in order to avoid flickering --- css/backoffice/components/_datatable.scss | 19 +++++++++++++++++++ .../components/datatable/layout.html.twig | 2 +- .../components/datatable/layout.ready.js.twig | 4 ++++ .../static/formtable/layout.html.twig | 2 +- .../static/formtable/layout.ready.js.twig | 4 ++++ .../datatable/static/layout.html.twig | 2 +- .../datatable/static/layout.ready.js.twig | 4 ++++ 7 files changed, 34 insertions(+), 3 deletions(-) diff --git a/css/backoffice/components/_datatable.scss b/css/backoffice/components/_datatable.scss index 89b0aeaee..63d5e3186 100644 --- a/css/backoffice/components/_datatable.scss +++ b/css/backoffice/components/_datatable.scss @@ -125,4 +125,23 @@ $ibo-fieldsorter--selected--background-color: $ibo-color-blue-200 !default; .ibo-datatable--selected-count, .ibo-datatable--result-count{ padding-right: 0.2em; padding-left: 0.1em; +} + +// +.ibo-datatable[data-status="loading"]{ + margin-top: $ibo-datatable--toolbar--table-spacing; + td, th { + position: relative; + padding: $ibo-vendors-datatables--cell--padding-y $ibo-vendors-datatables--cell--padding-x; + } + td{ + @extend %ibo-font-ral-med-100; + } + tr:nth-child(even){ + background-color: $ibo-vendors-datatables--row--background-color--is-even; + } + th { + @extend %ibo-font-ral-sembol-100; + border-bottom: $ibo-vendors-datatables--columns-header--border-bottom; + } } \ No newline at end of file diff --git a/templates/base/components/datatable/layout.html.twig b/templates/base/components/datatable/layout.html.twig index 4db597a8d..9b4550fda 100644 --- a/templates/base/components/datatable/layout.html.twig +++ b/templates/base/components/datatable/layout.html.twig @@ -12,7 +12,7 @@ {% endif %} {% endif %} - +
{% if oUIBlock.GetOption("select_mode") is not empty %} diff --git a/templates/base/components/datatable/layout.ready.js.twig b/templates/base/components/datatable/layout.ready.js.twig index 3b753c6c8..32ec7f0a0 100644 --- a/templates/base/components/datatable/layout.ready.js.twig +++ b/templates/base/components/datatable/layout.ready.js.twig @@ -339,6 +339,10 @@ var oTable{{ sListIDForVarSuffix }} = $('#{{ oUIBlock.GetId() }}').DataTable({ {% endfor %} {% endif %} {% endif %} + + // Set header and body datatables status as loaded + this.attr('data-status', 'loaded'); + this.closest('.dataTables_scroll').find('.dataTables_scrollHead .ibo-datatable').attr('data-status', 'loaded'); } }); diff --git a/templates/base/components/datatable/static/formtable/layout.html.twig b/templates/base/components/datatable/static/formtable/layout.html.twig index 9e2316217..8b8eb3327 100644 --- a/templates/base/components/datatable/static/formtable/layout.html.twig +++ b/templates/base/components/datatable/static/formtable/layout.html.twig @@ -4,7 +4,7 @@ {% set columns = oUIBlock.GetColumns() %} -
+
{% for column in columns %} diff --git a/templates/base/components/datatable/static/formtable/layout.ready.js.twig b/templates/base/components/datatable/static/formtable/layout.ready.js.twig index 0560a9ba7..cc5536cff 100644 --- a/templates/base/components/datatable/static/formtable/layout.ready.js.twig +++ b/templates/base/components/datatable/static/formtable/layout.ready.js.twig @@ -50,6 +50,10 @@ var oTable{{ sListIDForVarSuffix }} = $('#{{ oUIBlock.GetId() }}').DataTable({ { this.closest('.dataTables_wrapper').find('.dataTables_length').hide(); } + + // Set header and body datatables status as loaded + this.attr('data-status', 'loaded'); + this.closest('.dataTables_scroll').find('.dataTables_scrollHead .ibo-datatable').attr('data-status', 'loaded'); }, }); diff --git a/templates/base/components/datatable/static/layout.html.twig b/templates/base/components/datatable/static/layout.html.twig index c86274c76..c06a7b6b5 100644 --- a/templates/base/components/datatable/static/layout.html.twig +++ b/templates/base/components/datatable/static/layout.html.twig @@ -2,7 +2,7 @@ {# @license http://opensource.org/licenses/AGPL-3.0 #} {% set columns = oUIBlock.GetColumns() %} -
+
{% for column in columns %} diff --git a/templates/base/components/datatable/static/layout.ready.js.twig b/templates/base/components/datatable/static/layout.ready.js.twig index 30f94e0ee..d08866021 100644 --- a/templates/base/components/datatable/static/layout.ready.js.twig +++ b/templates/base/components/datatable/static/layout.ready.js.twig @@ -79,6 +79,10 @@ var oTable{{ sListIDForVarSuffix }} = $('#{{ oUIBlock.GetId() }}').DataTable({ { this.closest('.dataTables_wrapper').find('.dataTables_length').hide(); } + + // Set header and body datatables status as loaded + this.attr('data-status', 'loaded'); + this.closest('.dataTables_scroll').find('.dataTables_scrollHead .ibo-datatable').attr('data-status', 'loaded'); } });