composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 02:58:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Advanced search: Code cleanup.

Browse Source 
SVN:trunk[5699]
This commit is contained in:
Guillaume Lajarige
2018-04-20 09:01:48 +00:00
parent 18bd0ae096
commit 1f2b01937b
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
js/search/search_form_handler.js
View File

@@ -408,7 +408,7 @@ $(function()
for(var sFieldRef in this.options.search.fields.zlist)
{
var oFieldElem = me._getHtmlLiFromFieldRef(me, sFieldRef, ['zlist']);
var oFieldElem = me._getHtmlLiFromFieldRef(sFieldRef, ['zlist']);
oFieldElem.appendTo(oZListItemsElem);
}
@@ -429,7 +429,7 @@ $(function()
for(var sFieldRef in this.options.search.fields.others)
{
var oFieldElem = me._getHtmlLiFromFieldRef(me, sFieldRef, ['others']);
var oFieldElem = me._getHtmlLiFromFieldRef(sFieldRef, ['others']);
oFieldElem.appendTo(oOthersItemsElem);
}
}
@@ -746,10 +746,12 @@ $(function()
*
* @return jQuery detached <li />
*/
_getHtmlLiFromFieldRef: function(me, sFieldRef, aFieldCollectionsEligible) {
_getHtmlLiFromFieldRef: function(sFieldRef, aFieldCollectionsEligible) {
var me = this;
var oFieldElem = undefined;
aFieldCollectionsEligible.forEach(function (sFieldCollection) {
aFieldCollectionsEligible.forEach(function (sFieldCollection)
{
if (typeof me.options.search.fields[sFieldCollection][sFieldRef] == 'undefined')
{
return true;//if this field is not present in the Collection, let's try the next
@@ -765,7 +767,7 @@ $(function()
if (undefined == oFieldElem)
{
me._trace('no sFieldRef in given collection', {"sFieldRef":sFieldRef, "aFieldCollectionsEligible":aFieldCollectionsEligible});
this._trace('No sFieldRef "' + sFieldRef + '" in given collections', {"aFieldCollectionsEligible":aFieldCollectionsEligible});
return $('<!-- no sFieldRef in given collection -->');
}
@@ -1034,7 +1036,7 @@ $(function()
aHistory.forEach(function(sFieldRef) {
var oFieldElem = me._getHtmlLiFromFieldRef(me, sFieldRef, ['zlist', 'others']);
var oFieldElem = me._getHtmlLiFromFieldRef(sFieldRef, ['zlist', 'others']);
oRecentsItemsElem.append(oFieldElem);
});