composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-30 22:18:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°4756 - Ease extensibility for CRUD operations : 🎨 refactor after code review with PG

Browse Source
This commit is contained in:
Eric Espie
2023-01-26 17:32:02 +01:00
parent 5844717980
commit 1e37370789
13 changed files with 175 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sources/Application/Service/Events/EventData.php
View File

@@ -17,10 +17,10 @@ namespace Combodo\iTop\Service\Events;
*/
class EventData
{
private $sEvent;
private string $sEvent;
private $mEventSource;
private $aEventData;
private $aCallbackData;
private array $aEventData;
private array $aCallbackData;
/**
* EventServiceData constructor.
@@ -44,7 +44,7 @@ class EventData
* @api
* @return string Event fired.
*/
public function GetEvent()
public function GetEvent(): string
{
return $this->sEvent;
}
@@ -59,11 +59,11 @@ class EventData
*/
public function Get($sParam)
{
if (is_array($this->aEventData) && isset($this->aEventData[$sParam])) {
if (isset($this->aEventData[$sParam])) {
return $this->aEventData[$sParam];
}
if (is_array($this->aCallbackData) && isset($this->aCallbackData[$sParam])) {
if (isset($this->aCallbackData[$sParam])) {
return $this->aCallbackData[$sParam];
}
@@ -97,7 +97,7 @@ class EventData
*/
public function SetCallbackData($aCallbackData)
{
$this->aCallbackData = $aCallbackData;
$this->aCallbackData = $aCallbackData ?? [];
}
/**