diff --git a/core/log.class.inc.php b/core/log.class.inc.php index e05e920e0..e4eb09880 100644 --- a/core/log.class.inc.php +++ b/core/log.class.inc.php @@ -774,7 +774,7 @@ class DeadLockLog extends LogAPI return self::CHANNEL_WAIT_TIMEOUT; break; case 1213: - return self::CHANNEL_DEADLOCK_FOUND; + return self::CHANNEL_DEADLOCK_FOUND; break; default: return self::CHANNEL_DEFAULT; @@ -783,17 +783,21 @@ class DeadLockLog extends LogAPI } /** - * @param int $iMySQLErrNo will be converted to channel using {@link GetChannelFromMysqlErrorNo} + * @param string $sLevel * @param string $sMessage - * @param null $iMysqlErroNo + * @param int $iMysqlErrorNumber will be converted to channel using {@link GetChannelFromMysqlErrorNo} * @param array $aContext * * @throws \Exception + * @noinspection PhpParameterNameChangedDuringInheritanceInspection + * + * @since 2.7.1 method creation + * @since 2.7.5 3.0.0 rename param names and fix phpdoc (thanks Hipska !) */ - public static function Log($iMySQLErrNo, $sMessage, $iMysqlErroNo = null, $aContext = array()) + public static function Log($sLevel, $sMessage, $iMysqlErrorNumber = null, $aContext = array()) { - $sChannel = self::GetChannelFromMysqlErrorNo($iMysqlErroNo); - parent::Log($iMySQLErrNo, $sMessage, $sChannel, $aContext); + $sChannel = self::GetChannelFromMysqlErrorNo($iMysqlErrorNumber); + parent::Log($sLevel, $sMessage, $sChannel, $aContext); } } diff --git a/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_mosaic.html.twig b/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_mosaic.html.twig index ec2ddc92c..bd23c9aaf 100644 --- a/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_mosaic.html.twig +++ b/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_mosaic.html.twig @@ -397,15 +397,16 @@ } } }; - + + // N°3995: Loader is shown immediately, otherwise when we have a huge amount of items, we can have a bottleneck on the buildMosaic() function, blocking the display of the loader + showMosaicLoader(); $(document).ready(function(){ // Auto collapse item actions popup $('body').on('click', function(){ $('#brick_content_mosaic .item-action-wrapper.collapse.in').collapse('hide'); }); - // Build the tree (collapsed) - showMosaicLoader(); + // Build the mosaic (collapsed) buildMosaic(oRawDatas); hideMosaicLoader(); registerFilterListeners(); diff --git a/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_tree.html.twig b/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_tree.html.twig index b2aa2bd35..a343e0032 100644 --- a/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_tree.html.twig +++ b/datamodels/2.x/itop-portal-base/portal/templates/bricks/browse/mode_tree.html.twig @@ -321,6 +321,8 @@ } }; + // N°3995: Loader is shown immediately, otherwise when we have a huge amount of items, we can have a bottleneck on the buildTree() function, blocking the display of the loader + showTreeLoader(); $(document).ready(function(){ // Init expand/collapse all buttons $('#btn-collapse-all').on('click', function (oEvent) { @@ -405,7 +407,6 @@ }); // Build the tree (collapsed) - showTreeLoader(); buildTree(oRawDatas); hideTreeLoader(); registerFilterListeners(); diff --git a/setup/wizardsteps.class.inc.php b/setup/wizardsteps.class.inc.php index d5a5e6a45..dc3e8e150 100644 --- a/setup/wizardsteps.class.inc.php +++ b/setup/wizardsteps.class.inc.php @@ -1126,7 +1126,7 @@ class WizStepUpgradeMiscParams extends WizardStep public function Display(WebPage $oPage) { - $sApplicationURL = $this->oWizard->GetParameter('application_url', utils::GetAbsoluteUrlAppRoot(true)); //Preserve existing configuration. + $sApplicationURL = $this->oWizard->GetParameter('application_url', utils::GetAbsoluteUrlAppRoot(true)); //Preserve existing configuration (except for the str_replace based joker $SERVER_NAME$ which is lost) $sDefaultGraphvizPath = (strtolower(substr(PHP_OS, 0, 3)) === 'win') ? 'C:\\Program Files\\Graphviz\\bin\\dot.exe' : '/usr/bin/dot'; $sGraphvizPath = $this->oWizard->GetParameter('graphviz_path', $sDefaultGraphvizPath); $oPage->add('

Additional parameters

');