diff --git a/datamodels/2.x/itop-change-mgmt-itil/datamodel.itop-change-mgmt-itil.xml b/datamodels/2.x/itop-change-mgmt-itil/datamodel.itop-change-mgmt-itil.xml index 17766c1a8..3c1ed44d1 100755 --- a/datamodels/2.x/itop-change-mgmt-itil/datamodel.itop-change-mgmt-itil.xml +++ b/datamodels/2.x/itop-change-mgmt-itil/datamodel.itop-change-mgmt-itil.xml @@ -239,7 +239,7 @@ UserRequest parent_change_id - add_remove + add_remove 0 0 link @@ -248,7 +248,7 @@ Incident parent_change_id - add_remove + add_remove 0 0 link @@ -257,7 +257,7 @@ Problem related_change_id - add_remove + add_remove 0 0 link @@ -266,7 +266,7 @@ Change parent_id - add_remove + add_remove id]]> 0 0 diff --git a/datamodels/2.x/itop-change-mgmt/datamodel.itop-change-mgmt.xml b/datamodels/2.x/itop-change-mgmt/datamodel.itop-change-mgmt.xml index 595444076..7e810881d 100755 --- a/datamodels/2.x/itop-change-mgmt/datamodel.itop-change-mgmt.xml +++ b/datamodels/2.x/itop-change-mgmt/datamodel.itop-change-mgmt.xml @@ -178,7 +178,7 @@ UserRequest parent_change_id - add_remove + add_remove 0 0 link @@ -187,7 +187,7 @@ Incident parent_change_id - add_remove + add_remove 0 0 link @@ -196,7 +196,7 @@ Problem related_change_id - add_remove + add_remove 0 0 link @@ -205,7 +205,7 @@ Change parent_id - add_remove + add_remove id]]> 0 0 diff --git a/datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml b/datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml index 01bd8aed0..4ebefad36 100755 --- a/datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml +++ b/datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml @@ -100,7 +100,7 @@ SoftwareInstance system_id - in_place + in_place all 0 0 @@ -541,7 +541,7 @@ PhysicalInterface connectableci_id - in_place + in_place all 0 0 @@ -773,7 +773,7 @@ FiberChannelInterface datacenterdevice_id - in_place + in_place all 0 0 @@ -2064,7 +2064,7 @@ MiddlewareInstance middleware_id - in_place + in_place all 0 0 @@ -2195,7 +2195,7 @@ DatabaseSchema dbserver_id - in_place + in_place all 0 0 @@ -2326,7 +2326,7 @@ WebApplication webserver_id - in_place + in_place all 0 0 @@ -3080,7 +3080,7 @@ SoftwareInstance software_id - add_only + add_only 0 0 link @@ -3089,7 +3089,7 @@ SoftwarePatch software_id - add_only + add_only 0 0 link @@ -3098,7 +3098,7 @@ SoftwareLicence software_id - add_only + add_only 0 0 link @@ -3673,7 +3673,7 @@ VirtualMachine oslicence_id - none + none 0 0 link @@ -3682,7 +3682,7 @@ Server oslicence_id - none + none 0 0 link @@ -3818,7 +3818,7 @@ SoftwareInstance softwarelicence_id - none + none 0 0 link @@ -4145,7 +4145,7 @@ PhysicalDevice brand_id - add_only + add_only 0 0 @@ -4292,7 +4292,7 @@ PhysicalDevice model_id - add_only + add_only 0 0 @@ -4370,7 +4370,7 @@ NetworkDevice networkdevicetype_id - add_only + add_only 0 0 @@ -6551,7 +6551,7 @@ PhysicalDevice location_id - add_only + add_only 0 0 link diff --git a/datamodels/2.x/itop-datacenter-mgmt/datamodel.itop-datacenter-mgmt.xml b/datamodels/2.x/itop-datacenter-mgmt/datamodel.itop-datacenter-mgmt.xml index 27d300740..5a3ec6448 100755 --- a/datamodels/2.x/itop-datacenter-mgmt/datamodel.itop-datacenter-mgmt.xml +++ b/datamodels/2.x/itop-datacenter-mgmt/datamodel.itop-datacenter-mgmt.xml @@ -37,7 +37,7 @@ DatacenterDevice rack_id - add_only + add_only 0 0 link @@ -46,7 +46,7 @@ Enclosure rack_id - add_only + add_only 0 0 link @@ -233,7 +233,7 @@ DatacenterDevice enclosure_id - add_only + add_only 0 0 link @@ -579,7 +579,7 @@ PDU powerstart_id - add_only + add_only 0 0 link diff --git a/datamodels/2.x/itop-faq-light/datamodel.itop-faq-light.xml b/datamodels/2.x/itop-faq-light/datamodel.itop-faq-light.xml index 50d6c8dae..f66d13ebe 100755 --- a/datamodels/2.x/itop-faq-light/datamodel.itop-faq-light.xml +++ b/datamodels/2.x/itop-faq-light/datamodel.itop-faq-light.xml @@ -173,7 +173,7 @@ FAQ category_id - add_only + add_only 0 0 link diff --git a/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml b/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml index 3d372c107..fca105a26 100755 --- a/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml +++ b/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml @@ -442,7 +442,7 @@ UserRequest parent_incident_id - add_remove + add_remove 0 0 link @@ -451,7 +451,7 @@ Incident parent_incident_id - add_remove + add_remove 0 0 link diff --git a/datamodels/2.x/itop-problem-mgmt/datamodel.itop-problem-mgmt.xml b/datamodels/2.x/itop-problem-mgmt/datamodel.itop-problem-mgmt.xml index de27cd48f..96ee54def 100755 --- a/datamodels/2.x/itop-problem-mgmt/datamodel.itop-problem-mgmt.xml +++ b/datamodels/2.x/itop-problem-mgmt/datamodel.itop-problem-mgmt.xml @@ -204,7 +204,7 @@ KnownError problem_id - add_only + add_only 0 0 link @@ -213,7 +213,7 @@ UserRequest parent_problem_id - add_remove + add_remove 0 0 link @@ -222,7 +222,7 @@ Incident parent_problem_id - add_remove + add_remove 0 0 link diff --git a/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml b/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml index 3e4ac19cc..76b6f7206 100755 --- a/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml +++ b/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml @@ -501,7 +501,7 @@ UserRequest parent_request_id - add_remove + add_remove 0 0 link diff --git a/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml b/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml index 576a5a2cc..30676cb5f 100755 --- a/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml +++ b/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml @@ -529,7 +529,7 @@ UserRequest parent_request_id - add_remove + add_remove 0 0 link diff --git a/datamodels/2.x/itop-service-mgmt-provider/datamodel.itop-service-mgmt-provider.xml b/datamodels/2.x/itop-service-mgmt-provider/datamodel.itop-service-mgmt-provider.xml index 6341443eb..38b808a50 100755 --- a/datamodels/2.x/itop-service-mgmt-provider/datamodel.itop-service-mgmt-provider.xml +++ b/datamodels/2.x/itop-service-mgmt-provider/datamodel.itop-service-mgmt-provider.xml @@ -962,7 +962,7 @@ public function PrefillSearchForm(&$aContextParam) Service servicefamily_id - add_only + add_only 0 0 @@ -1123,7 +1123,7 @@ public function PrefillSearchForm(&$aContextParam) ServiceSubcategory service_id - add_only + add_only 0 0 @@ -2297,7 +2297,7 @@ public function PrefillSearchForm(&$aContextParam) Organization deliverymodel_id - add_remove + add_remove 0 0 diff --git a/datamodels/2.x/itop-service-mgmt/datamodel.itop-service-mgmt.xml b/datamodels/2.x/itop-service-mgmt/datamodel.itop-service-mgmt.xml index 2ffac257b..fd0fb54b8 100755 --- a/datamodels/2.x/itop-service-mgmt/datamodel.itop-service-mgmt.xml +++ b/datamodels/2.x/itop-service-mgmt/datamodel.itop-service-mgmt.xml @@ -932,7 +932,7 @@ public function PrefillSearchForm(&$aContextParam) Service servicefamily_id - add_only + add_only 0 0 @@ -1111,7 +1111,7 @@ public function PrefillSearchForm(&$aContextParam) ServiceSubcategory service_id - add_only + add_only 0 0 @@ -1599,7 +1599,7 @@ public function PrefillSearchForm(&$aContextParam) sla_id 0 0 - none + none link true @@ -2218,7 +2218,7 @@ public function PrefillSearchForm(&$aContextParam) Organization deliverymodel_id - add_remove + add_remove 0 0 link diff --git a/datamodels/2.x/itop-storage-mgmt/datamodel.itop-storage-mgmt.xml b/datamodels/2.x/itop-storage-mgmt/datamodel.itop-storage-mgmt.xml index dcc734fae..3f52bad9c 100644 --- a/datamodels/2.x/itop-storage-mgmt/datamodel.itop-storage-mgmt.xml +++ b/datamodels/2.x/itop-storage-mgmt/datamodel.itop-storage-mgmt.xml @@ -30,7 +30,7 @@ LogicalVolume storagesystem_id - in_place + in_place all 0 0 @@ -532,7 +532,7 @@ Tape tapelibrary_id - in_place + in_place all 0 0 @@ -782,7 +782,7 @@ NASFileSystem nas_id - in_place + in_place all 0 0 diff --git a/datamodels/2.x/itop-structure/datamodel.itop-structure.xml b/datamodels/2.x/itop-structure/datamodel.itop-structure.xml index 46f8e99e9..5f5e18c9c 100644 --- a/datamodels/2.x/itop-structure/datamodel.itop-structure.xml +++ b/datamodels/2.x/itop-structure/datamodel.itop-structure.xml @@ -282,7 +282,7 @@ Person location_id - add_only + add_only 0 0 link diff --git a/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml b/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml index 7160a5814..ef66ee5c7 100755 --- a/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml +++ b/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml @@ -777,7 +777,7 @@ Ticket caller_id - add_only + add_only 0 0 link @@ -799,7 +799,7 @@ Ticket team_id - none + none 0 0 link diff --git a/datamodels/2.x/itop-virtualization-mgmt/datamodel.itop-virtualization-mgmt.xml b/datamodels/2.x/itop-virtualization-mgmt/datamodel.itop-virtualization-mgmt.xml index e8f78fe9b..8b99ee32d 100644 --- a/datamodels/2.x/itop-virtualization-mgmt/datamodel.itop-virtualization-mgmt.xml +++ b/datamodels/2.x/itop-virtualization-mgmt/datamodel.itop-virtualization-mgmt.xml @@ -170,7 +170,7 @@ VirtualMachine virtualhost_id - add_only + add_only 0 0 link @@ -440,7 +440,7 @@ Hypervisor farm_id - add_only + add_only 0 0 link @@ -631,7 +631,7 @@ LogicalInterface virtualmachine_id - in_place + in_place all 0 0 diff --git a/setup/itopdesignformat.class.inc.php b/setup/itopdesignformat.class.inc.php index 8553c6859..11a70398b 100644 --- a/setup/itopdesignformat.class.inc.php +++ b/setup/itopdesignformat.class.inc.php @@ -1058,9 +1058,6 @@ class iTopDesignFormat $oEditModeNode = $oLinkedSetEditModeNodes->item(0); /** @noinspection NullPointerExceptionInspection already checked */ $sEditMode = $oEditModeNode->nodeValue; - $oLegacyEditModeNode = $oNode->ownerDocument->createElement('legacy_edit_mode', $sEditMode); - /** @noinspection NullPointerExceptionInspection already checked */ - $oNode->replaceChild($oLegacyEditModeNode, $oEditModeNode); } switch ($sEditMode) { @@ -1120,15 +1117,6 @@ class iTopDesignFormat // - restore edit_mode attribute from legacy_edit_mode attribute $this->RemoveNodeFromXPath("/itop_design/classes//class/fields/field[@xsi:type='AttributeLinkedSet']/read_only"); $this->RemoveNodeFromXPath("/itop_design/classes//class/fields/field[@xsi:type='AttributeLinkedSet']/relation_type"); - $oLegacyEditModeNodesList = $oXPath->query("/itop_design/classes//class/fields/field[@xsi:type='AttributeLinkedSet']/legacy_edit_mode"); - /** @var \DOMElement $oLegacyEditModeNode */ - foreach ($oLegacyEditModeNodesList as $oLegacyEditModeNode) { - $sEditMode = $oLegacyEditModeNode->nodeValue; - $oEditModeNode = $oLegacyEditModeNode->ownerDocument->createElement('edit_mode', $sEditMode); - $oLinkedSetNode = $oLegacyEditModeNode->parentNode; - /** @noinspection NullPointerExceptionInspection already checked */ - $oLinkedSetNode->replaceChild($oEditModeNode, $oLegacyEditModeNode); - } // N°5563 AttributeLinkedSetIndirect // - remove read_only attribute (added in 3.1) diff --git a/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.0_to_3.1.expected.xml b/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.0_to_3.1.expected.xml index 2e1b99815..a9efc79cc 100644 --- a/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.0_to_3.1.expected.xml +++ b/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.0_to_3.1.expected.xml @@ -4,7 +4,7 @@ - none + none link true @@ -13,7 +13,7 @@ - add_only + add_only link false @@ -22,7 +22,7 @@ - add_remove + add_remove link false @@ -31,7 +31,7 @@ - actions + actions link false @@ -40,7 +40,7 @@ - in_place + in_place property false diff --git a/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.1_to_3.0.input.xml b/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.1_to_3.0.input.xml index 58c0769a8..3be0991e7 100644 --- a/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.1_to_3.0.input.xml +++ b/tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.1_to_3.0.input.xml @@ -4,7 +4,7 @@ - none + none link true @@ -13,7 +13,7 @@ - add_only + add_only link false @@ -22,7 +22,7 @@ - add_remove + add_remove link false @@ -31,7 +31,7 @@ - actions + actions link false @@ -40,7 +40,7 @@ - in_place + in_place property false