composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 02:58:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°2272 - OQL performance (comments)

Browse Source
This commit is contained in:
Eric
2019-09-13 10:40:28 +02:00
parent a8d5630030
commit 128afc8a56
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/sqlobjectquerybuilder.class.inc.php
View File

@@ -183,9 +183,6 @@ class SQLObjectQueryBuilder
// -> ext keys required for a friendly name // -> ext keys required for a friendly name
// //
$aExtKeys = array(); // array of sTableClass => array of (sAttCode (keys) => array of (sAttCode (fields)=> oAttDef)) $aExtKeys = array(); // array of sTableClass => array of (sAttCode (keys) => array of (sAttCode (fields)=> oAttDef))
//
// Optimization: could be partially computed once for all (cached) ?
//
// Get all Ext keys used by the filter // Get all Ext keys used by the filter
foreach ($this->oDBObjetSearch->GetCriteria_PointingTo() as $sKeyAttCode => $aPointingTo) foreach ($this->oDBObjetSearch->GetCriteria_PointingTo() as $sKeyAttCode => $aPointingTo)
@@ -416,7 +413,7 @@ class SQLObjectQueryBuilder
} }
} }
// Additional JOINS for Friendly names // Additional JOINS for polymorphic expressions (friendlyname, obsolescenceflag...)
// //
foreach ($aFNJoinAlias as $sSubClass => $sSubClassAlias) foreach ($aFNJoinAlias as $sSubClass => $sSubClassAlias)
{ {
@@ -464,15 +461,12 @@ class SQLObjectQueryBuilder
$bIsOnQueriedClass = array_key_exists($sTargetAlias, $oBuild->GetRootFilter()->GetSelectedClasses()); $bIsOnQueriedClass = array_key_exists($sTargetAlias, $oBuild->GetRootFilter()->GetSelectedClasses());
//self::DbgTrace("Entering: tableclass=$sTableClass, filter=".$this->oDBObjetSearch->ToOQL().", ".($bIsOnQueriedClass ? "MAIN" : "SECONDARY"));
// 1 - SELECT and UPDATE // 1 - SELECT and UPDATE
// //
// Note: no need for any values nor fields for foreign Classes (ie not the queried Class) // Note: no need for any values nor fields for foreign Classes (ie not the queried Class)
// //
$aUpdateValues = array(); $aUpdateValues = array();
// 1/a - Get the key and friendly name // 1/a - Get the key and friendly name
// //
// We need one pkey to be the key, let's take the first one available // We need one pkey to be the key, let's take the first one available
@@ -486,7 +480,7 @@ class SQLObjectQueryBuilder
$oSelectedIdField = $oIdField; $oSelectedIdField = $oIdField;
} }
// 1/b - Get the other attributes // 1/b - Prepare Update attributes
// //
foreach(MetaModel::ListAttributeDefs($sTableClass) as $sAttCode=>$oAttDef) foreach(MetaModel::ListAttributeDefs($sTableClass) as $sAttCode=>$oAttDef)
{ {
@@ -557,7 +551,7 @@ class SQLObjectQueryBuilder
$aPointingTo = $this->oDBObjetSearch->GetCriteria_PointingTo($sKeyAttCode); $aPointingTo = $this->oDBObjetSearch->GetCriteria_PointingTo($sKeyAttCode);
if (!array_key_exists(TREE_OPERATOR_EQUALS, $aPointingTo)) if (!array_key_exists(TREE_OPERATOR_EQUALS, $aPointingTo))
{ {
// The join was not explicitely defined in the filter, // The join was not explicitly defined in the filter,
// we need to do it now // we need to do it now
$sKeyClass = $oKeyAttDef->GetTargetClass(); $sKeyClass = $oKeyAttDef->GetTargetClass();
$sKeyClassAlias = $oBuild->GenerateClassAlias($sKeyClass.'_'.$sKeyAttCode, $sKeyClass); $sKeyClassAlias = $oBuild->GenerateClassAlias($sKeyClass.'_'.$sKeyAttCode, $sKeyClass);