From 110a03090276d2c948fa6549d8cf9f1532d95bd3 Mon Sep 17 00:00:00 2001
From: Molkobain <lajarige.guillaume@free.fr>
Date: Tue, 4 Feb 2020 16:15:52 +0100
Subject: [PATCH] PHPDoc

---
 .../portal/src/Form/ObjectFormManager.php     | 28 +++++--------------
 .../src/Helper/ObjectFormHandlerHelper.php    | 18 ++++++------
 2 files changed, 16 insertions(+), 30 deletions(-)

diff --git a/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php b/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php
index a2257168bc..caf45c4201 100644
--- a/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php
+++ b/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php
@@ -83,20 +83,15 @@ class ObjectFormManager extends FormManager
 	protected $aCallbackUrls = array();
 	/** @var boolean $bIsSubmittable */
 	protected $bIsSubmittable = true;
-	
+
 	/**
 	 * Creates an instance of \Combodo\iTop\Portal\Form\ObjectFormManager from JSON data that must contain at least :
 	 * - formobject_class : The class of the object that is being edited/viewed
 	 * - formmode : view|edit|create
 	 * - values for parent
 	 *
-	 * @param string $sJson
-	 *
-	 * @return $this
-	 *
+	 * @inheritDoc
 	 * @throws \Exception
-	 * @throws \ArchivedObjectException
-	 * @throws \CoreException
 	 */
 	static function FromJSON($sJson)
 	{
@@ -328,13 +323,7 @@ class ObjectFormManager extends FormManager
 	}
 
 	/**
-	 * Creates a JSON string from the current object including :
-	 * - formobject_class
-	 * - formobject_id
-	 * - formmode
-	 * - values for parent
-	 *
-	 * @return array
+	 * @inheritDoc
 	 */
 	public function ToJSON()
 	{
@@ -352,6 +341,7 @@ class ObjectFormManager extends FormManager
 	}
 
 	/**
+	 * @inheritDoc
 	 * @throws \CoreException
 	 * @throws \OQLException
 	 * @throws \Exception
@@ -1040,9 +1030,7 @@ class ObjectFormManager extends FormManager
 	}
 
 	/**
-	 * Calls all form fields OnCancel method in order to delegate them the cleanup;
-	 *
-	 * @param array $aArgs
+	 * @inheritDoc
 	 *
 	 * @throws \CoreException
 	 * @throws \CoreUnexpectedValue
@@ -1078,9 +1066,7 @@ class ObjectFormManager extends FormManager
 	 *          'errors' => array()
 	 *    )
 	 *
-	 * @param array $aArgs
-	 *
-	 * @return array
+	 * @inheritDoc
 	 *
 	 * @throws \ArchivedObjectException
 	 * @throws \CoreException
@@ -1199,7 +1185,7 @@ class ObjectFormManager extends FormManager
 	 *
 	 * Note : Doesn't update the object, see ObjectFormManager::OnSubmit() for that;
 	 *
-	 * @param array $aArgs
+	 * @inheritDoc
 	 *
 	 * @throws \ArchivedObjectException
 	 * @throws \CoreException
diff --git a/datamodels/2.x/itop-portal-base/portal/src/Helper/ObjectFormHandlerHelper.php b/datamodels/2.x/itop-portal-base/portal/src/Helper/ObjectFormHandlerHelper.php
index 3b53c964e7..5abb765c38 100644
--- a/datamodels/2.x/itop-portal-base/portal/src/Helper/ObjectFormHandlerHelper.php
+++ b/datamodels/2.x/itop-portal-base/portal/src/Helper/ObjectFormHandlerHelper.php
@@ -57,25 +57,25 @@ class ObjectFormHandlerHelper
 	/** @var string ENUM_MODE_CREATE */
 	const ENUM_MODE_CREATE = 'create';
 
-	/** @var \Combodo\iTop\Portal\Helper\RequestManipulatorHelper */
+	/** @var \Combodo\iTop\Portal\Helper\RequestManipulatorHelper $oRequestManipulator */
 	private $oRequestManipulator;
-	/** @var \Combodo\iTop\Portal\Helper\ContextManipulatorHelper */
+	/** @var \Combodo\iTop\Portal\Helper\ContextManipulatorHelper $oContextManipulator */
 	private $oContextManipulator;
-	/** @var \Combodo\iTop\Portal\Helper\NavigationRuleHelper */
+	/** @var \Combodo\iTop\Portal\Helper\NavigationRuleHelper $oNavigationRuleHelper */
 	private $oNavigationRuleHelper;
-	/** @var \Combodo\iTop\Portal\Helper\ScopeValidatorHelper */
+	/** @var \Combodo\iTop\Portal\Helper\ScopeValidatorHelper $oScopeValidator */
 	private $oScopeValidator;
-	/** @var \Combodo\iTop\Portal\Helper\SecurityHelper */
+	/** @var \Combodo\iTop\Portal\Helper\SecurityHelper $oSecurityHelper */
 	private $oSecurityHelper;
-	/** @var \Combodo\iTop\Portal\Routing\UrlGenerator */
+	/** @var \Combodo\iTop\Portal\Routing\UrlGenerator $oUrlGenerator */
 	private $oUrlGenerator;
-	/** @var array */
+	/** @var array $aCombodoPortalInstanceConf */
 	private $aCombodoPortalInstanceConf;
 	/** @var string $sPortalId */
 	private $sPortalId;
-	/** @var \Combodo\iTop\Portal\Twig\AppExtension */
+	/** @var \Combodo\iTop\Portal\Twig\AppExtension $oAppExtension */
 	private $oAppExtension;
-	/** @var \Symfony\Component\DependencyInjection\ContainerInterface */
+	/** @var \Symfony\Component\DependencyInjection\ContainerInterface $oContainer */
 	private $oContainer;
 
 	/**