From 85d50f31bd7978c46efcd9a904b338862c634193 Mon Sep 17 00:00:00 2001 From: "lenaick.moreira" Date: Fri, 17 Jul 2026 17:05:06 +0200 Subject: [PATCH] =?UTF-8?q?:white=5Fcheck=5Fmark:=20N=C2=B09692=20-=20Fix?= =?UTF-8?q?=20null=20coalescing=20for=20extension=20installation=20status?= =?UTF-8?q?=20and=20clean=20up=20test=20cases?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- setup/wizardsteps/WizStepModulesChoice.php | 2 +- .../unitary-tests/setup/WizStepModulesChoiceTest.php | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/setup/wizardsteps/WizStepModulesChoice.php b/setup/wizardsteps/WizStepModulesChoice.php index 3f829bc45a..567c5f6ea8 100644 --- a/setup/wizardsteps/WizStepModulesChoice.php +++ b/setup/wizardsteps/WizStepModulesChoice.php @@ -750,7 +750,7 @@ EOF $bSelected = isset($aSelectedComponents[$sChoiceId]) && ($aSelectedComponents[$sChoiceId] === $sChoiceId); $bMissingFromDisk = isset($aChoice['missing']) && $aChoice['missing'] === true; $bMandatory = (isset($aChoice['mandatory']) && $aChoice['mandatory']); - $bInstalled = $bMissingFromDisk || $oITopExtension->bInstalled; + $bInstalled = $bMissingFromDisk || $oITopExtension?->bInstalled ?? false; $bDependencyIssue = $oITopExtension?->HasDependencyIssue() ?? false; $bChecked = $bSelected; diff --git a/tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php b/tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php index b0b8618bfd..66dd565c54 100644 --- a/tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php +++ b/tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php @@ -78,9 +78,6 @@ class WizStepModulesChoiceTest extends ItopTestCase ], 'A missing extension should be disabled and unchecked' => [ 'aExtensionsOnDiskOrDb' => [ - 'itop-ext1' => [ - 'installed' => false, - ], ], 'aWizardStepDefinition' => [ 'extension_code' => 'itop-ext1', @@ -102,9 +99,6 @@ class WizStepModulesChoiceTest extends ItopTestCase ], 'A missing extension should always be disabled and unchecked, even when mandatory' => [ 'aExtensionsOnDiskOrDb' => [ - 'itop-ext1' => [ - 'installed' => false, - ], ], 'aWizardStepDefinition' => [ 'extension_code' => 'itop-ext1', @@ -126,9 +120,6 @@ class WizStepModulesChoiceTest extends ItopTestCase ], 'A missing extension should always be disabled and unchecked, even when non-uninstallable' => [ 'aExtensionsOnDiskOrDb' => [ - 'itop-ext1' => [ - 'installed' => false, - ], ], 'aWizardStepDefinition' => [ 'extension_code' => 'itop-ext1',